Infrastructure: mock utf8 for changelog script (fix PTBs) #5821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
demonnic
approved these changes
Jan 7, 2022
There was a problem hiding this comment.
This seems fine to me, but should we consider moving the new function I broke things with to a new file for utf8 stuff, or mock it in the StringUtils.lua file instead?
Any of the solutions seem alright, but those two options leave StringUtils.lua functionally viable on its own
vadi2
added a commit
that referenced
this pull request
Jan 7, 2022
#### Brief overview of PR changes/additions Document places StringUtils.lua is used in #### Motivation for adding to Mudlet To reduce the likelihood of breaking `generate-ptb-changelog.lua` again. #### Other info (issues closed, discussion etc) #5821 Co-authored-by: Damian Monogue <3660+demonnic@users.noreply.github.com>
vadi2
added a commit
to SlySven/Mudlet
that referenced
this pull request
Jan 17, 2022
vadi2
added a commit
to SlySven/Mudlet
that referenced
this pull request
Jan 17, 2022
#### Brief overview of PR changes/additions Document places StringUtils.lua is used in #### Motivation for adding to Mudlet To reduce the likelihood of breaking `generate-ptb-changelog.lua` again. #### Other info (issues closed, discussion etc) Mudlet#5821 Co-authored-by: Damian Monogue <3660+demonnic@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
The changelog generation script broke as soon as was utf8.patternEscape was merged because it loads
StringUtils.luaseparately without dragging inLuaGlobal.luaand all of the dependencies that would drag in.Motivation for adding to Mudlet
Fix PTBs deployment, which rely on Windows builds to be done first. No Windows builds = no other builds either. This shouldn't be so fragile, but it's the best we've got because of how github actions work.