Improve: properly size unicode 13 and 14 emojis #5915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Delwing
approved these changes
Jan 24, 2022
|
Note: widecharwidth added a new return value |
Well, yeah, I was the one who asked for it...! |
|
Thanks for the reminder @faho! Never hurts to double-check on this. |
|
Current release, doesn't know how wide the unicode 13 emoji 🤌 should be:
This PR, knows how wide it should be:
|
vadi2
changed the title
SlySven
reviewed
Apr 10, 2022
Co-authored-by: Stephen Lyons <slysven@virginmedia.com>
demonnic
approved these changes
Apr 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Start on support for unicode 13 and 14 emojis - start because this will just make them be drawn not squished, but we still depend on the right fonts to be available on the system to actually draw them.
Also re-enable widechar width updates now that we have a solution for it, see ridiculousfish/widecharwidth#11.
Motivation for adding to Mudlet
Keep up with the emojis.
Other info
widechar_non_characterproperty was added that needs handling - haven't dove into what it means for us just yet.Closes #5910.