Infrastructure: update en_US plural translations workflow

[FloXire]

Brief overview of PR changes/additions

Add new workflow to automatically update the file containing american english plural sentences (still requires someone to do the pluralization job).

Motivation for adding to Mudlet

This PR should facilitate the associated step of the release process by gradually doing the job and automating the three first sub steps.

Other info (issues closed, discussion etc)

Related to #5858.

I found out that dealing with all the edge cases to fully automate the process with automatic translations would be too complicated so I chose to create a draft PR so that contributors can add their commit with plural forms to it. Tell me if that's fine. Also tell me if the cron frequency is ok or if I should change it.

Two questions:

• Should I create an issue referencing the draft PR to tell contributors that there are sentences to pluralize ?
• Sometimes there is no new sentence to pluralize but there are still changes in the generated translations/translated/mudlet_en_US.ts file (to indicate that the location of the sentence in the source file changed). Should I also create a PR in that case (not a draft one) ?

Release post highlight

[add-deployment-links]

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

• linux: https://make.mudlet.org/snapshots/248cf9/Mudlet-4.15.0-testing-pr5956-04f3d699-linux-x64.AppImage.tar
• osx: https://make.mudlet.org/snapshots/7328ff/Mudlet-4.15.0-testing-pr5956-04f3d699.dmg
• windows: https://make.mudlet.org/snapshots/1175b7/Mudlet-4.15.0-testing-pr5956-31ffef3b-windows.zip

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

[github-actions]

	Messages
✔️	PR type: Infrastructure

Generated by 🚫 dangerJS against 04f3d69

[vadi2]

Thanks @FloXire! Will review it tomorrow.

[vadi2]

Thanks for the PR, it's a nice step towards more automation 👍

create a draft PR so that contributors can add their commit with plural forms to it.

Yep that sounds fine. @SlySven do you want to take up the job of adding plural translations? As far as I know we do not have anybody doing this job at the moment, so we need someone to cover the PRs that will be generated.

Also tell me if the cron frequency is ok or if I should change it.

Yep that is fine. Could you just check or close an existing PR, so we only have 1 open on this subject?

Should I create an issue referencing the draft PR to tell contributors that there are sentences to pluralize ?

Not needed, PR is enough.

Sometimes there is no new sentence to pluralize but there are still changes in the generated translations/translated/mudlet_en_US.ts file (to indicate that the location of the sentence in the source file changed). Should I also create a PR in that case (not a draft one) ?

No, let's only create one if there is actual pluralization work to be done. Yes it means the line numbers will be wrong, but that is a very trivial problem we have been ignoring. See here on how to ignore line # changes only.

[SlySven]

Yep that sounds fine. @SlySven do you want to take up the job of adding plural translations? As far as I know we do not have anybody doing this job at the moment, so we need someone to cover the PRs that will be generated.

Okay, I don't expect to be overwhelmed by this as the last time I checked there was only 15 or so.

Though that does remind me that that blind Arabic translator did find one place where we didn't have an %n when we should have done (Discord #translation channel 2022/02/01) - so there may be a forthcoming PR that will be able to test this...! 😀

[FloXire]

Could you just check or close an existing PR, so we only have 1 open on this subject?

I'm not sure I understand this correctly. What you want is that if there's already an existing PR I do not create a new one right ?

@SlySven so should I add you as an assignee whenever such a PR is automatically created ?

[vadi2]

What you want is that if there's already an existing PR I do not create a new one right ?

Ideally update it, because there's new content now, right?

[FloXire]

What you want is that if there's already an existing PR I do not create a new one right ?

Ideally update it, because there's new content now, right?

Right I think I can make it work like that using a fixed name branch. Also currently the PR title to update plural form is set to add: .... Would you prefer Infrastructure: ... as it was the case for this PR ?

[vadi2]

Infrastructure, please.

[SlySven]

@SlySven so should I add you as an assignee whenever such a PR is automatically created ?

Yeah...

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[FloXire]

Alright everything should be fine now but let me know if there are more changes you'd like to see.

[vadi2]

Looks good to me. Let's give it a spin :)

[vadi2]

Looks like there's no unfinished ones at the moment? https://github.com/Mudlet/Mudlet/runs/5175712644?check_suite_focus=true

[FloXire]

Looks like there's no unfinished ones at the moment? https://github.com/Mudlet/Mudlet/runs/5175712644?check_suite_focus=true

No indeed. In fact, when I was testing it I had to manually introduce new changes in the code in order to see a created PR with the new sentences.

[vadi2]

Awesome. Thank you for your contribution to Mudlet's release process :)

Hopefully we'll see more!

[SlySven]

Like I said in #5956 (comment) there are only a few (13 to 15 IIRC) in our code (there is a pair that someone in Discord said they found that needs implementing where a %2 needs converting to a %n):

 QString IrcMessageFormatter::formatNamesMessage(IrcNamesMessage* message, bool isForLua)
 {
     const QString count = QString::number(message->names().count());
     if (isForLua) {
         // lua actually needs the names for parsing, since getting a names
         // list from the UI userModel alone would be limiting to the IRC commands.
         QString nameList = message->names().join(" ");
-        return QObject::tr("! %1 has %2 users: %3").arg(message->channel(), count, nameList);
+        return QObject::tr("! %1 has %n user(s): %2", "", count).arg(message->channel(), nameList);
     } else {
-        return QObject::tr("! %1 has %2 users").arg(message->channel(), count);
+        return QObject::tr("! %1 has %n user(s)", "", count).arg(message->channel());
     }
 }