Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: getAreaExits does not return special exits #5963

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

keneanung
Copy link
Member

Brief overview of PR changes/additions

The lua interface function getAreaExits(<area-id>, true) did not return area exits through special exits, which it used to do in earlier versions and is documented in the wiki.

Motivation for adding to Mudlet

Fix a lost feature, even though it went unnoticed for a longer time.

Other info (issues closed, discussion etc)

Discussion on the IRE-Mudlet-Mapping discord with the user Nunya.

@keneanung keneanung requested review from a team as code owners February 9, 2022 13:13
@add-deployment-links
Copy link

add-deployment-links bot commented Feb 9, 2022

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

@mudlet-machine-account mudlet-machine-account added this to the 4.16.0 milestone Feb 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2022

Messages
✔️

PR type: Fix

Generated by 🚫 dangerJS against 7785b2f

@vadi2
Copy link
Member

vadi2 commented Feb 9, 2022

Oh wow, that is really sneaky code. Nice fix!

Copy link
Member

@SlySven SlySven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤯 Ouch! I did that in #4526. When I was swapping from the QMultiMap<int, QString> that was being used for the Special exits (and their lock statuses) to a more sensible (AFAICT) QMap<QString, int> for just the exitRoomId...

@keneanung
Copy link
Member Author

Confirmed as working by users.

@keneanung keneanung merged commit 47b3014 into Mudlet:development Feb 9, 2022
@keneanung keneanung deleted the fix-get-area-exits branch February 9, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants