Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: setLabelDoubleClickCallback arguments work again as documented #5970

Merged
merged 3 commits into from
Mar 12, 2022

Conversation

Edru2
Copy link
Member

@Edru2 Edru2 commented Feb 11, 2022

Brief overview of PR changes/additions

see Title

Motivation for adding to Mudlet

fix #5967

Other info (issues closed, discussion etc)

@Edru2 Edru2 requested a review from a team as a code owner February 11, 2022 09:42
@add-deployment-links
Copy link

add-deployment-links bot commented Feb 11, 2022

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

@mudlet-machine-account mudlet-machine-account added this to the 4.16.0 milestone Feb 11, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2022

Messages
✔️

PR type: Fix

Generated by 🚫 dangerJS against 9585e74

src/mudlet-lua/lua/GUIUtils.lua Outdated Show resolved Hide resolved
Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
@vadi2
Copy link
Member

vadi2 commented Feb 25, 2022

@Edru2 merge latest development in please so the windows checks pass OK.

@vadi2 vadi2 enabled auto-merge (squash) March 12, 2022 14:24
@vadi2 vadi2 merged commit 4a2f306 into Mudlet:development Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geyser.Label:setDoubleClickCallback (func, ...) doesnt seem to pass arguments as documented
3 participants