Fix: correctly read state of map info contributors from profile XML #5976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
|
clang-tidy review says "All clean, LGTM! 👍" |
Fix: fix reading map info contributors
Delwing
force-pushed
the
map-info-contributors-bugfixes
branch
from
4e31dd1
to
824f530
Compare
vadi2
approved these changes
Feb 14, 2022
|
@vadi2 can you rerun appveyor build please? |
…tributors-bugfixes
…tributors-bugfixes
|
All good now |
|
Not sure why clangtidy suddenly failing. |
|
Checked the build log? Looks like an action issue, should be reported |
|
I guess it complains about complexity of |
|
Seems fine to me to merge this time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Just as title says... there were two bugs.
After flattening XML it was not longer easy to say, that user selected none of map info contributors or came from old save file.
While fixing that, I've noticed that I used wrong attribute name for reading map info contributors.
Motivation for adding to Mudlet
Other info (issues closed, discussion etc)