-
-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: stopSounds() for triggers #5977
Conversation
vadim's feedback for sound API
…udlet-development
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
clang-tidy review says "All clean, LGTM! 👍" |
Co-authored-by: Stephen Lyons <slysven@virginmedia.com>
Verified on windows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice on getting rid of old code :)
Brief overview of PR changes/additions
Enables the
play sound
feature of triggers to use the Lua API so that sounds could be controlled via the API. Fixes a problem where stopSounds() is not working for sounds created with triggers, per an issue reported referenced below.Motivation for adding to Mudlet
Corrects oversight introduced in 4.15 and reduces code.
Other info (issues closed, discussion etc)
Resolves #5974.
-Tamarindo@StickMUD