Fix: Handle sound files in subdirectories

[mpconley]

Brief overview of PR changes/additions

Fix an issue where sound files would not play in sub directories.

Note: This issue was reduced to focus on this error. Another method was determined to use a trigger and the API to achieve MSP without negotiation.

Motivation for adding to Mudlet

User reported.

Other info (issues closed, discussion etc)

Mudlet Discord user Qvazir#2882, a game admin, reported this issue.

[add-deployment-links]

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

• linux: https://make.mudlet.org/snapshots/b4a4a3/Mudlet-4.15.1-testing-pr5984-cbb019b0-linux-x64.AppImage.tar
• osx: https://make.mudlet.org/snapshots/04bd38/Mudlet-4.15.1-testing-pr5984-cbb019b0.dmg
• windows: https://make.mudlet.org/snapshots/decff1/Mudlet-4.15.1-testing-pr5984-cbb019b0-windows.zip

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

[github-actions]

	Messages
✔️	PR type: Improvement

Generated by 🚫 dangerJS against cbb019b

[vadi2]

This is not a great way to go about it - in this case I'd question the request because it's bending the convention, and not in a good way. Do we know why can't the game enable it like all others do?

[mpconley]

• We'd prefer everyone use negotiations for MSP.
• Qvazir of AndorMUD has periodically reminded me of this request since @vadi2 referred me last month.
• Andor MUD returned online from a long hiatus. They have MSP embedded in many commands. They are not in a position to negotiate anything. Clients of the past are no longer an alternative.
• Clients and MUDs do not have to use negotiations for MSP.
• Per the MSP specification, "If the server does not implement telnet option negotiation, then..."
• The number of games negotiating with MSP vs. those that are not negotiating with MSP is an unknown.
• With this pull request, Mudlet finds a way to increase support for the MSP specification without changing much code or highlighting this practice elsewhere prominently.

[SlySven]

• Andor MUD returned online from a long hiatus.

Yeah it went down in 2009 and returned in August last year, see http://www.mudstats.com/World/AndorMUD and it averages 2 players online since then. The last time the listed URL for it's web-site had anything relevant for it was in 2001! https://web.archive.org/web/20010927052030/http://mud.skota.org:80/ - however some digging located it now at https://mud.rootix.se/ which redirects to: https://andormud.se/ .

Though this "Andor" is nothing to do with the country of that name in the Wheel of Time world - or the Disney+ series prequel to the Star Wars "Rogue one" film.

[vadi2]

Expanding the scope of receiveMSP() to also turn protocols on/off is not the right way, but let's work on a solution that will help the game in the end. Is MSP enabled by default in zmud/cmud/mushclient/kmuddy without any telnet negotiation whatsoever?

[mpconley]

Please review this approach, thanks!

[vadi2]

Still not so hot on this (because this gives ground to other force enable protocol functions, which is not how it should work), interested in the answer on -

Is MSP enabled by default in zmud/cmud/mushclient/kmuddy without any telnet negotiation whatsoever?

[mpconley]

No feedback from Reddit or the Mud Discord on this. Someone thought it was like that in Zmud. I like the change taking it out of receiveMSP(). This helps meet that specification. We could advise best practice in documentation, with this as a work-around to meet the standard for games that support MSP but not negotiation.

[mpconley]

We're going to ask for some help to make the trigger call the new sound APIs as another way to do this. I do need to get a bug fix integrated we discovered along the way that impacts MCMP and MSP where sub-directories are used.