Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: map info bg can be customized through mapper colors preferences #5994

Merged
merged 2 commits into from
Mar 10, 2022

Conversation

Delwing
Copy link
Contributor

@Delwing Delwing commented Feb 27, 2022

Brief overview of PR changes/additions

I'll put a picture instead of description :)
image

Motivation for adding to Mudlet

Other info (issues closed, discussion etc)

@Delwing Delwing requested review from a team as code owners February 27, 2022 14:32
@add-deployment-links
Copy link

add-deployment-links bot commented Feb 27, 2022

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

@mudlet-machine-account mudlet-machine-account added this to the 4.16.0 milestone Feb 27, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 27, 2022

Messages
✔️

PR type: Addition

Generated by 🚫 dangerJS against baae5b9

@vadi2
Copy link
Member

vadi2 commented Feb 27, 2022

LGTM. Just needs testing

Copy link
Member

@SlySven SlySven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will also need to add the new pushButton into the right place in the Tab stop list - fortunately the Qt editor has gotten a bit easier in recent versions and you can actually move the items in the list in there, instead of hand-editing the .ui file. Select the "Mapper colors" tab in the editor and click on the fourth tab to go into "Tab stop" mode - then use the context "Right click" (1) menu to "Set tab order..." select (2) and move (3) the pushButton_mapInfoBg control to the right place (around 106 I think) - the numbers in the list might update when you hit "Ok" (4)...
image

src/Host.cpp Outdated Show resolved Hide resolved
src/Host.h Outdated Show resolved Hide resolved
src/dlgProfilePreferences.h Outdated Show resolved Hide resolved
src/ui/profile_preferences.ui Outdated Show resolved Hide resolved
src/ui/profile_preferences.ui Outdated Show resolved Hide resolved
@Delwing Delwing merged commit f487536 into Mudlet:development Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants