-
-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infrastructure: install Qt 5.14.2 using aqtinstaller for Windows #6030
Conversation
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Strange error:
Configure output:
Going to re-run the build. |
Error is fixed, it's all good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to block this but you need to also remove ./CU/qt-silent-install.qs
from the repository to avoid leaving it as cruft...
Sure, removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
During running of the CI builds on AppVeyor for Windows we now are getting errors during the `.configure` stage for the build of PCRE - and we get the advices to try using the additional `--disable-dependency-tracking` to fix it. This PR tried to do that to see if it fixed things, but it didn't. Further investigation by @keneanung and myself eventually revealed that although #6030 installed Qt it was not installing the expected Mingw GCC compiler (32-bit 7.3.0) - further digging revealed that an addition step was needed to do that. During the investigation I spotted that when building `libzip` we were also building the regression tests, the documentation and the examples - none of which are used or needed by our Windows CI builds. So disabling them should reduce the build time slightly and there was no point to undoing the change that disabled their being built. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Brief overview of PR changes/additions
Motivation for adding to Mudlet
Other info (issues closed, discussion etc)
This might also fix it for the desktop, non-CI compilation people are doing - but that is not the intent of this PR just yet.