Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infrastructure: install Qt 5.14.2 using aqtinstaller for Windows #6030

Merged
merged 4 commits into from
Apr 7, 2022

Conversation

vadi2
Copy link
Member

@vadi2 vadi2 commented Apr 3, 2022

Brief overview of PR changes/additions

Motivation for adding to Mudlet

Other info (issues closed, discussion etc)

This might also fix it for the desktop, non-CI compilation people are doing - but that is not the intent of this PR just yet.

@add-deployment-links
Copy link

add-deployment-links bot commented Apr 3, 2022

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

@mudlet-machine-account mudlet-machine-account added this to the 4.16.0 milestone Apr 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2022

Messages
✔️

PR type: Infrastructure

Generated by 🚫 dangerJS against fa46ec6

@vadi2 vadi2 changed the title Infrastructure: fix Windows CI builds to work (install Qt 5.14.2 ourselves) Infrastructure: install Qt 5.14.2 using aqtinstaller for Windows Apr 3, 2022
@vadi2
Copy link
Member Author

vadi2 commented Apr 3, 2022

Strange error:

==== compiling and installing pcre ====
---- Downloading ----
---- Extracting source distribution ----
---- Running configure ----
Error executing command: bash
At C:\projects\mudlet\CI\appveyor.functions.ps1:[82](https://ci.appveyor.com/project/Mudlet/mudlet/builds/43113186#L82) char:5
+     throw $errorMessage
+     ~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : OperationStopped: (Error executing command: bash:String) [], RuntimeException
    + FullyQualifiedErrorId : Error executing command: bash

Configure output:

onfigure: creating ./config.status
config.status: creating Makefile
config.status: creating libpcre.pc
config.status: creating libpcre16.pc
config.status: creating libpcre32.pc
config.status: creating libpcreposix.pc
config.status: creating libpcrecpp.pc
config.status: creating pcre-config
config.status: creating pcre.h
config.status: creating pcre_stringpiece.h
config.status: creating pcrecpparg.h
config.status: creating config.h
config.status: executing depfiles commands
config.status: error: in `/c/src/pcre/pcre-8.45':
config.status: error: Something went wrong bootstrapping makefile fragments
    for automatic dependency tracking.  If GNU make was not used, consider
    re-running the configure script with MAKE="gmake" (or whatever is
    necessary).  You can also try re-running configure with the
    '--disable-dependency-tracking' option to at least be able to build
    the package (albeit without support for automatic dependency tracking).
See `config.log' for more details

Going to re-run the build.

@vadi2 vadi2 marked this pull request as ready for review April 3, 2022 12:24
@vadi2 vadi2 requested a review from a team as a code owner April 3, 2022 12:24
@vadi2
Copy link
Member Author

vadi2 commented Apr 5, 2022

Error is fixed, it's all good now.

Copy link
Member

@SlySven SlySven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to block this but you need to also remove ./CU/qt-silent-install.qs from the repository to avoid leaving it as cruft...

@vadi2
Copy link
Member Author

vadi2 commented Apr 7, 2022

Sure, removed.

Copy link
Member

@SlySven SlySven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vadi2 vadi2 merged commit ec5eefa into development Apr 7, 2022
@vadi2 vadi2 deleted the swap-aqtinstaller branch April 7, 2022 18:59
vadi2 pushed a commit that referenced this pull request Apr 22, 2022
During running of the CI builds on AppVeyor for Windows we now are getting errors during the `.configure` stage for the build of PCRE - and we get the advices to try using the additional `--disable-dependency-tracking` to fix it. This PR tried to do that to see if it fixed things, but it didn't.

Further investigation by @keneanung and myself eventually revealed that although #6030 installed Qt it was not installing the expected Mingw GCC compiler (32-bit 7.3.0) - further digging revealed that an addition step was needed to do that.

During the investigation I spotted that when building `libzip` we were also building the regression tests, the documentation and the examples - none of which are used or needed by our Windows CI builds. So disabling them should reduce the build time slightly and there was no point to undoing the change that disabled their being built.

Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants