Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infrastructure: add resilience to macOS notarization process #6047

Merged
merged 3 commits into from
Apr 8, 2022

Conversation

vadi2
Copy link
Member

@vadi2 vadi2 commented Apr 8, 2022

Brief overview of PR changes/additions

Try to notarize thrice until it works.

Motivation for adding to Mudlet

Notarization is dependent upon Apple's infrastructure, which is highly, but not 100% reliable. When it's not, it breaks out builds which is unnecessary overhead - try to reduce that by giving notarization a few tries.

Other info (issues closed, discussion etc)

Close #5601.

@add-deployment-links
Copy link

add-deployment-links bot commented Apr 8, 2022

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

@mudlet-machine-account mudlet-machine-account added this to the 4.16.0 milestone Apr 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2022

Messages
✔️

PR type: Infrastructure

Generated by 🚫 dangerJS against 3f80ca6

@vadi2 vadi2 marked this pull request as ready for review April 8, 2022 11:04
@vadi2 vadi2 requested a review from a team as a code owner April 8, 2022 11:04
@vadi2 vadi2 merged commit 66905ab into development Apr 8, 2022
@vadi2 vadi2 deleted the try-notarization-thrice branch April 8, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add resilience to notarization process
3 participants