Add: screenreader-friendly main window #6090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First, rename mLastRenderBottom to mLastRenderedOffset. The old name is misleading because it actually holds the line that was at the top of the screen when it was last rendered, not the bottom. Also add explanation of what mScrollVector means. These changes help understand the logic at TTextEdit::drawForeground().
TConsole is best viewer as a container of other widgets, rather than a widget itself. Therefore, it makes more sense to add accessibility support to its inner widgets.
…ibleTextEdit Thanks to Stephen Lyons for the suggestion.
Use plain strings rather than QStringLiterals. The QStringLiteral() versions add annoying double quotes to the output. Also, use function calls rather than streams to output the messages. The syntax is more compact and allows for better control of the formatting.
… interface_cast() QAccessibleWidget's version already does that for us. Also take the opportunity to remove some unnecessary headers.
Rely on the superclass' implementation.
It's redundant, because QAccessibleWidget's constructor already takes a role argument.
This communicates that they're internal helpers for the class implementation and aren't used anywhere else.
…contents ... as oposed to assuming that every (x, y) coordinate contains a character.
The current cursor position isn't relevant in the calculation.
This fixes the following warning: 'TAccessibleTextEdit::text' hides overloaded virtual function Adjust lineForOffset() and cursorPosition() to take into account the newlines added by join(). Also, simplify text(int startOffset, int endOffset) using the new text(QAccessible::Text t) method.
… on the last char
Support only selection 0.
…and textAtOffset()
It's partially based on QAccessibleTextWidget::attributes() from Qt 5.15.
Also, remove ‘DocumentContentChanged’ event from TConsole::print() methods because both call TTextEdit::showNewLines(), which already sends ‘TextInsertEvent’.
demonnic
approved these changes
Jul 23, 2022
|
Thanks a lot for the review! |
SlySven
added a commit
to SlySven/Mudlet
that referenced
this pull request
Aug 6, 2022
…2/MINGW-W64 The error messages that this was producing were somewhat obscure but only appeared in my MSYS2/Mingw-w64 based Windows setup (where I have the environmental variable `WITH_MAIN_BUILD_SYSTEM` defined to `"NO"`)! The result of it however was that any build based on code since Mudlet#6090 went in was failing... Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
SlySven
added a commit
that referenced
this pull request
Aug 6, 2022
…2/MINGW-W64 (#6218) The error messages that this was producing were somewhat obscure but only appeared in my MSYS2/Mingw-w64 based Windows setup (where I have the environmental variable `WITH_MAIN_BUILD_SYSTEM` defined to `"NO"`)! The result of it however was that any build based on code since #6090 went in was failing... Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
SlySven
added a commit
to SlySven/Mudlet
that referenced
this pull request
Aug 7, 2022
Mudlet#6090 added the library to the QMake LIBS variable for the main build system but it is in fact needed also for the MSYS2/Mingw-w64 setup (that I use) as well so needs to be put in a different location in the main QMake project file. Whilst checking to see if the CMake alternative worked in my setup I noticed that there is a typo in the adjecent line for the "ws2_32" library. The documentation at, say: https://docs.microsoft.com/en-us/windows/win32/winsock/initialization-2 calls it `Ws2_32`, however the files in a Windows filesystem (and the corresponding line in the CMake build file): ``` if(WIN32) target_link_libraries(mudlet ws2_32) ... endif() ``` specifies an all-lower case (library file) name - this is possibly okay because of the way that Windows handles file names but it is probably better to use the same thing all around. I note that though we list both `libws2_32` and `liboleut32` in the QMake project files it seems that only the former needs (?) to be mentioned in the CMake case - limited experimentation I've done on my setup suggests that the latter is linked in automagically without being explictly stated! Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
SlySven
added a commit
that referenced
this pull request
Aug 7, 2022
…#6220) #6090 added the library to the QMake LIBS variable for the main build system but it is in fact needed also for the MSYS2/Mingw-w64 setup (that I use) as well so needs to be put in a different location in the main QMake project file. Whilst checking to see if the CMake alternative worked in my setup I noticed that there is a typo in the adjacent line for the "ws2_32" library. The documentation at, say: https://docs.microsoft.com/en-us/windows/win32/winsock/initialization-2 calls it `Ws2_32`, however the files in a Windows filesystem (and the corresponding line in the CMake build file): ``` if(WIN32) target_link_libraries(mudlet ws2_32) ... endif() ``` specifies an all-lower case (library file) name - this is possibly okay because of the way that Windows handles file names but it is probably better to use the same thing all around. I note that though we list both `libws2_32` and `liboleut32` in the QMake project files it seems that only the former needs (?) to be mentioned in the CMake case - limited experimentation I've done on my setup suggests that the latter is linked in automagically without being explicitly stated! Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
This was referenced Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Screenreader-friendly main window.
Motivation for adding to Mudlet
Crucial part of accessibility support in Mudlet
Other info (issues closed, discussion etc)
Addresses #3342 but doesn't close it, as we'd like to migrate to using PTBs for the follow-up improvements.
This focuses on the main window only, and will not tackle other accessibility issues such as miniconsoles or any of the issues in menus.
Builds on the excellent work of @bauermann in #5985. Windows announcements are helped by code from both Osara and Qt.
edit: This comment has links to downloads: #6090 (comment)