Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Read map UserData from JSON map files #6191

Merged
merged 3 commits into from Aug 1, 2022

Conversation

keneanung
Copy link
Member

Brief overview of PR changes/additions

This enables Mudlet to read map USerData from map files.

Motivation for adding to Mudlet

Feature parity between binary and JSON map imports. I assume this was an oversight.

Other info (issues closed, discussion etc)

@keneanung keneanung requested review from a team as code owners July 29, 2022 20:05
@add-deployment-links
Copy link

add-deployment-links bot commented Jul 29, 2022

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

@keneanung keneanung changed the title Read map UserData from JSON map files Bugfix: Read map UserData from JSON map files Jul 29, 2022
@keneanung keneanung changed the title Bugfix: Read map UserData from JSON map files Fix: Read map UserData from JSON map files Jul 29, 2022
Copy link
Member

@SlySven SlySven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... I assume this was an oversight.

Um, mea culpa... 😊

src/TMap.cpp Outdated Show resolved Hide resolved
Co-authored-by: Stephen Lyons <slysven@virginmedia.com>
@keneanung keneanung enabled auto-merge (squash) August 1, 2022 07:16
@mudlet-machine-account mudlet-machine-account added this to the 4.17.0 milestone Aug 1, 2022
@keneanung keneanung merged commit 2c0cc5b into Mudlet:development Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants