Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Video capability for MCMP and Lua API #6439
base: development
Are you sure you want to change the base?
Add: Video capability for MCMP and Lua API #6439
Changes from 9 commits
7c4bced
cf5230b
1b2a22e
8aa0cb9
5c5a37b
7d635aa
ec37367
5721a1f
0d692e9
f4d1f20
a6472b5
f6d583e
5de86c3
42268de
f543ab4
b59b749
dc17605
cf4d5b1
0ad1741
8ed2980
9bb779c
ab27222
c6ca669
565883c
6fc091d
5e1fb57
570eedd
039f8e2
86e333e
c4e6289
13aca7e
71a9745
3b5f687
044b751
c9cda17
91b2d86
5d139ba
53b3318
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure this counts as a warning - unlike the mapper I do not know whether it is possible to completely remove an extant "video player" whereas we only ever hide (but do not destroy) the mapper (which causes other issues if the user wishes to change from one embedded in a console to a floating/dockable one - as it cannot be done without closing the profile - which I would not like to see replicated in this new feature...!)