Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infrastructure: Remove "experimental" name from package exporter menu, etc. #6456

Merged
merged 1 commit into from Dec 11, 2022
Merged

Infrastructure: Remove "experimental" name from package exporter menu, etc. #6456

merged 1 commit into from Dec 11, 2022

Conversation

Kebap
Copy link
Contributor

@Kebap Kebap commented Dec 9, 2022

Brief overview of PR changes/additions

Remove any mentions of "experimental" around package UI

Motivation for adding to Mudlet

Vadi wrote in #5226 on May 13, 2021:

I imagine after 3-4 months if everything is going well, we can finally take the labels off 馃憤

That was 1.5 years ago now. We didn't hear from any folks having trouble with the package exporter either.

Other info (issues closed, discussion etc)

Follow-up to #6454 - see discussion there and in #5226 itself already.

@Kebap Kebap requested review from a team as code owners December 9, 2022 20:33
@add-deployment-links
Copy link

add-deployment-links bot commented Dec 9, 2022 •
edited

Hey there! Thanks for helping Mudlet improve. 馃専

Test versions

You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

@mudlet-machine-account mudlet-machine-account added this to the 4.17.0 milestone Dec 9, 2022
SlySven
SlySven approved these changes Dec 10, 2022
View reviewed changes
Copy link
Member

@SlySven SlySven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes sense to me.

@Kebap Kebap merged commit 437d613 into Mudlet:development Dec 11, 2022
@Kebap Kebap deleted the experiment_successful branch December 11, 2022 14:45
@vadi2
Copy link
Member

vadi2 commented Dec 23, 2022

Hmm, perhaps 'Infrastructure' was not the right label as this is something the players will see.

@Kebap
Copy link
Contributor Author

Kebap commented Dec 23, 2022

Fair enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadi2 vadi2 vadi2 approved these changes

@SlySven SlySven SlySven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.17.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Kebap @vadi2 @SlySven @mudlet-machine-account