Fix: correct search for Lua interpreter for qmake builds #6616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discord user **#Caith#8202** discovered that building Mudlet on aarch64 i.e. the Arm64 platform on Fedora fails (see the Mudlet **#help** channel on Discord starting 2023/03/06 03:55 UTC with the text): > lua-yajl is the bane of my existence. edited the hell out of the cmake scripts and mudlet.pro to finally get it to start using lua 5.1 instead of 5.4, then had to rig up some hunspell junk, but no matter what i do, qmake won't cooperate with the lua-yajl install. > > compiles fine on ubuntu and arch, so i'm bewildered. One detail that came to light is that on that system the 5.1 version of the Lua interpreter is called `lua-5.1` but that is not one of the names that `./translations/translated/updateqm.pri` tries so it fails to generate/update the binary translations for inclusion in the project. This PR should extend the tries to a fourth one that will handle that form, it also restructures the code slightly as it looked to me as the Windows OS handling was off. The corresponding CMake build file has also been updated to handle the same four variants - prior to that it only tried two which might not have worked in all cases. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
vadi2
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discord user #Caith#8202 discovered that building Mudlet on aarch64 i.e. the Arm64 platform on Fedora fails (see the Mudlet #help channel on Discord starting 2023/03/06 03:55 UTC with the text):
One detail that came to light is that on that system the 5.1 version of the Lua interpreter is called
lua-5.1but that is not one of the names that./translations/translated/updateqm.pritries so it fails to generate/update the binary translations for inclusion in the project.This PR should extend the tries to a fourth one that will handle that form, it also restructures the code slightly as it looked to me as the Windows OS handling was off.
The corresponding CMake build file has also been updated to handle the same four variants - prior to that it only tried two which might not have worked in all cases.
Signed-off by: Stephen Lyons slysven@virginmedia.com