add MMCP Development Preview #7155
Conversation
Sync with development branch
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Further revisions
There was a problem hiding this comment.
This isn't a change intended to be merged at this point - instead it marks the lines that must be reverted should this PR ever get to be merged into the main development branch. As such ("1 change requested") it should form a blocker on anyone accidentally trying to do that! 😁
| # PLACEMARKER: revert "MMCP" back to "dev" in the next three lines before merging this code into the main development branch: | ||
| file(WRITE ${CMAKE_SOURCE_DIR}/src/app-build.txt "-MMCP-${GIT_SHA1}") | ||
| message(STATUS "Value written to app-build.txt file: -MMCP-${GIT_SHA1}") | ||
| set(APP_BUILD "-MMCP" CACHE STRING "This variable is automatically set during the CMake run and should not be manually altered!" FORCE) |
There was a problem hiding this comment.
| # PLACEMARKER: revert "MMCP" back to "dev" in the next three lines before merging this code into the main development branch: | |
| file(WRITE ${CMAKE_SOURCE_DIR}/src/app-build.txt "-MMCP-${GIT_SHA1}") | |
| message(STATUS "Value written to app-build.txt file: -MMCP-${GIT_SHA1}") | |
| set(APP_BUILD "-MMCP" CACHE STRING "This variable is automatically set during the CMake run and should not be manually altered!" FORCE) | |
| file(WRITE ${CMAKE_SOURCE_DIR}/src/app-build.txt "-dev-${GIT_SHA1}") | |
| message(STATUS "Value written to app-build.txt file: -dev-${GIT_SHA1}") | |
| set(APP_BUILD "-dev" CACHE STRING "This variable is automatically set during the CMake run and should not be manually altered!" FORCE) |
| # PLACEMARKER: revert "MMCP" back to "dev" before merging this code into the main development branch: | ||
| BUILD = "-MMCP-"$${GIT_SHA1} |
There was a problem hiding this comment.
| # PLACEMARKER: revert "MMCP" back to "dev" before merging this code into the main development branch: | |
| BUILD = "-MMCP-"$${GIT_SHA1} | |
| BUILD = "-dev-"$${GIT_SHA1} |
|
Ah I meant the change in cTelnet in getNewEnvironTerminalName() or whichever method. Can’t look at it atm I’m in the middle of getting kids in bed. I had that qsl (“MUDLET”)‘line set to the mudlet scmVersion as temporary because we don’t support GMCP yet and would like to track mudlet versions that people are using during our adoption campaign.Sent from my iPhoneOn Mar 20, 2024, at 6:05 PM, Stephen Lyons ***@***.***> wrote:
@SlySven requested changes on this pull request.
This isn't a change intended to be merge at this point - instead it marks the lines that must be revert should this PR ever get to be merged into the main development branch. As such it should form a blocker on anyone accidentally trying to do that! 😁
In CMakeLists.txt:
+ # PLACEMARKER: revert "MMCP" back to "dev" in the next three lines before merging this code into the main development branch:
+ file(WRITE ${CMAKE_SOURCE_DIR}/src/app-build.txt "-MMCP-${GIT_SHA1}")
+ message(STATUS "Value written to app-build.txt file: -MMCP-${GIT_SHA1}")
+ set(APP_BUILD "-MMCP" CACHE STRING "This variable is automatically set during the CMake run and should not be manually altered!" FORCE)
⬇️ Suggested change
- # PLACEMARKER: revert "MMCP" back to "dev" in the next three lines before merging this code into the main development branch:
- file(WRITE ${CMAKE_SOURCE_DIR}/src/app-build.txt "-MMCP-${GIT_SHA1}")
- message(STATUS "Value written to app-build.txt file: -MMCP-${GIT_SHA1}")
- set(APP_BUILD "-MMCP" CACHE STRING "This variable is automatically set during the CMake run and should not be manually altered!" FORCE)
+ file(WRITE ${CMAKE_SOURCE_DIR}/src/app-build.txt "-dev-${GIT_SHA1}")
+ message(STATUS "Value written to app-build.txt file: -dev-${GIT_SHA1}")
+ set(APP_BUILD "-dev" CACHE STRING "This variable is automatically set during the CMake run and should not be manually altered!" FORCE)
In src/mudlet.pro:
+# PLACEMARKER: revert "MMCP" back to "dev" before merging this code into the main development branch:
+ BUILD = "-MMCP-"$${GIT_SHA1}
⬇️ Suggested change
-# PLACEMARKER: revert "MMCP" back to "dev" before merging this code into the main development branch:
- BUILD = "-MMCP-"$${GIT_SHA1}
+ BUILD = "-dev-"$${GIT_SHA1}
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
This latest push includes Medievia specific code to support our installer-free distribution. I probably should have started a new renamed branch, will do that next time.. since the path forward for MMCP to be included will be in Lua eventually |
|
Right, and getting Medievia listed by default is just a matter of putting together a decent, minimum experience for the players. |
Working on this as well. Current hangups are getting the mapper working and GMCP. I have the mapper mostly working currently however the newbie area is very large with many rooms having the same name so the mapper gets sometimes confused when walking around in a loop and reconnecting the tail end back to an existing mapped room. Editing this to be correct is very tedious. |
|
In the case of same named rooms and same exits, without any identifying information (like a vnum or a hash) one of the ways of getting of getting it fixed would be to go manual and use the visual editor or aliases. It would be very hard for automation to tell one thing apart from the other without outside knowledge. |
|
This is what I've resorted to trying.. always ran into a snag that somehow confused the mapper regarding which room I am in, and I can't seem to recover after that. I'll take a deeper look soon I am currently strung out between several projects sigh |
|
Also try using |
Brief overview of PR changes/additions
Add MMCP Client and Server classes, Lua scriptability, and options for the MudMaster Chat Protocol
Motivation for adding to Mudlet
This is a feature largely requested by players of the Medievia MUD, it allows peer to peer client communication integrated directly into the main console.
Other info (issues closed, discussion etc)
This is a preview as support for MMCP is ultimately desired to be implemented mostly as a Lua package.