Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve: add comment for translators for GMCP auth #7283

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

vadi2
Copy link
Member

@vadi2 vadi2 commented Jun 23, 2024

Brief overview of PR changes/additions

Add comment for translators for GMCP auth

Motivation for adding to Mudlet

Give translators a better an idea of what kind of text can go there

Other info (issues closed, discussion etc)

See #7202

@vadi2 vadi2 requested a review from a team as a code owner June 23, 2024 05:10
@vadi2 vadi2 requested a review from a team June 23, 2024 05:10
@add-deployment-links
Copy link

add-deployment-links bot commented Jun 23, 2024

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

src/GMCPAuthenticator.cpp Outdated Show resolved Hide resolved
Co-authored-by: Kebap <kebap_spam@gmx.net>
@Kebap Kebap merged commit 01fa2db into development Jul 1, 2024
10 checks passed
@Kebap Kebap deleted the add-gmcp-auth-comment branch July 1, 2024 12:23
mobley-trent added a commit to mobley-trent/Mudlet that referenced this pull request Jul 31, 2024
Updated mudlet.cpp - `.mpackage` instead of `.xml` files

Added default_packages.qrc

retrigger checks

Updated default_packages.qrc

Infrastructure: Bump carlosperate/download-file-action from 2.0.1 to 2.0.2 (Mudlet#7297)

Bumps
[carlosperate/download-file-action](https://github.com/carlosperate/download-file-action)
from 2.0.1 to 2.0.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/carlosperate/download-file-action/releases">carlosperate/download-file-action's
releases</a>.</em></p>
<blockquote>
<h2>v2.0.2</h2>
<h2>What's Changed</h2>
<ul>
<li><a
href="https://github.com/carlosperate/download-file-action/commit/1efd0068d62b2acbdfb4505299b2867446f89acb">Update
to node20 to avoid deprecation warnings.</a></li>
<li>Build(deps-dev): Bump braces from 3.0.2 to 3.0.3 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/carlosperate/download-file-action/pull/37">carlosperate/download-file-action#37</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/carlosperate/download-file-action/compare/v2...v2.0.2">https://github.com/carlosperate/download-file-action/compare/v2...v2.0.2</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/carlosperate/download-file-action/commit/3ec6fcef61e19eaaa0236a95fbaf333f2baf341e"><code>3ec6fce</code></a>
Action: Uprev to 2.0.2</li>
<li><a
href="https://github.com/carlosperate/download-file-action/commit/fd11bd396ecdbc987718c0de133fcb6d59f426e0"><code>fd11bd3</code></a>
CI: Update actions used.</li>
<li><a
href="https://github.com/carlosperate/download-file-action/commit/1efd0068d62b2acbdfb4505299b2867446f89acb"><code>1efd006</code></a>
Action: Update to node20 to avoid deprecation warnings.</li>
<li><a
href="https://github.com/carlosperate/download-file-action/commit/5d427692f444e5ccca5f90e16691e27f6e6edf9f"><code>5d42769</code></a>
Build(deps-dev): Bump braces from 3.0.2 to 3.0.3 (<a
href="https://redirect.github.com/carlosperate/download-file-action/issues/37">#37</a>)</li>
<li>See full diff in <a
href="https://github.com/carlosperate/download-file-action/compare/v2.0.1...v2.0.2">compare
view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=carlosperate/download-file-action&package-manager=github_actions&previous-version=2.0.1&new-version=2.0.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)

</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Improve: Simplify Mute Options (Mudlet#7296)

<!-- Keep the title short & concise so anyone non-technical can
understand it,
     the title appears in PTB changelogs -->
Reduce the quantity of mute options to more usable choices

@vadi2

Reference [Discord
request](https://discord.com/channels/283581582550237184/283582439002210305/1255734617349296179).

Improve: add comment for translators for GMCP auth (Mudlet#7283)

<!-- Keep the title short & concise so anyone non-technical can
understand it,
     the title appears in PTB changelogs -->
Add comment for translators for GMCP auth
Give translators a better an idea of what kind of text can go there
See Mudlet#7202

---------

Co-authored-by: Kebap <kebap_spam@gmx.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants