This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
Fix getting products on iOS 4.2.1 #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial products request is saved in a property, so that it isn't deleted right after leaving the requestProductData method.
MugunthKumar
added a commit
that referenced
this pull request
May 13, 2012
Fix getting products on iOS 4.2.1
|
Thanks for this. |
acrist
pushed a commit
to Coppertino/MKStoreKit
that referenced
this pull request
Jul 10, 2013
…roducts Fix getting products on iOS 4.2.1
acrist
pushed a commit
to Coppertino/MKStoreKit
that referenced
this pull request
Jul 10, 2013
…roducts Fix getting products on iOS 4.2.1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've come across a situation when product data isn't retrieved from the server. Neither productsRequest:didReceiveResponse: nor request:didFailWithError: was called. Apparently, the products request was deleted before calling a delegate's method. This happened very frequently on iPod 4.2.1, and sometimes on iPad 4.3.3. It seems a part of the issue may be slow internet access.
I keep the request in a property, and the thing works great now.