Skip to content
This repository has been archived by the owner on Dec 26, 2022. It is now read-only.

Fix build issues in get-task branch #38

Merged
merged 2 commits into from
Apr 25, 2021
Merged

Conversation

MattTennison
Copy link
Collaborator

What?

get-task branch was producing build errors #26 (comment)

Full message: package org.eclipse.jdt.internal.compiler.ast does not exist

Looks like that import isn't required for the class.
Looks like modelToTurtle has been deleted, but serialiseModelToTurtle
exists in the AbstractMUDController. So I inherited the controller from
that - not sure if that's what we want, but sounds like the right thing?
@MattTennison MattTennison mentioned this pull request Apr 25, 2021
@calummackervoy
Copy link
Member

Thanks for fixing this! :D

I see so I'd somehow imported org.eclipse.jdt.internal.compiler.ast.ThisReference; and then we weren't even using it 🤦 actually the error log made this pretty clear, I feel ashamed 😁

@calummackervoy calummackervoy merged commit 321f7ae into get-task Apr 25, 2021
@calummackervoy calummackervoy deleted the get-task-build-fix branch July 27, 2021 20:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants