Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updater broke on linux because of recent upgrades #1060

Closed
5 of 6 tasks
peterix opened this issue Jun 7, 2015 · 0 comments
Closed
5 of 6 tasks

Updater broke on linux because of recent upgrades #1060

peterix opened this issue Jun 7, 2015 · 0 comments
Assignees
@peterix
Labels
bug infrastructure
Milestone
0.4.8

Comments

@peterix
Copy link
Member

peterix commented Jun 7, 2015

  • Use known good versions for now - store them on s3 and just add them to the builds.
  • Remove updater from codebase
  • merge Qt-based updater with MultiMC itself (could be a library that handles these things)
  • fix internal update logic not working on XP, where you can't rename running binaries
  • download into an 'update' folder guaranteed to be on the same drive as MultiMC
  • preserve changed exe name on Windows

The only problem is that Windows can't rewrite running/in use binaries and libraries. This can be worked around by renaming the files first.
Rollback can be done by running a second instance with the new files:

  • if it crashes/doesn't run, roll back.
  • if it runs, exit
  • clean up moved files on next start

The XP fix will be MultiMC creating a tiny batch script that swaps the exe.
@peterix peterix added this to the 0.4.8 milestone Jun 7, 2015
peterix added a commit that referenced this issue Jun 7, 2015
@peterix
GH-1060 remove updater code
6d7bff2
@peterix peterix self-assigned this Jun 7, 2015
peterix added a commit that referenced this issue Jun 8, 2015
@peterix
GH-1060 remove some old updater bits and pieces
166813c
peterix added a commit that referenced this issue Jun 8, 2015
@peterix
GH-1060 implement very basic updater (only linux and maybe osx right …
82e0566 
…now)
peterix added a commit that referenced this issue Jun 8, 2015
@peterix
GH-1060 tweaks to new update mechanism - logging
64b70ac
peterix added a commit that referenced this issue Jun 9, 2015
@peterix
GH-1060 add a lot of error checking and reporting to the inner updater
22c5ced
peterix added a commit that referenced this issue Jun 9, 2015
@peterix
GH-1060 update tweaks
15b7c30 
* download to multimc folder hierarchy
* use rename, not copy
* keep backup after update
* clean previous backup before update
* it's not 'copy', it's 'replace'
peterix added a commit that referenced this issue Jun 9, 2015
@peterix
GH-1060 create and delete update dir
88f5c8d
peterix added a commit that referenced this issue Jun 10, 2015
@peterix
GH-1060 ugly XP hack is ugly
dd97ea8
@peterix peterix closed this as completed Jun 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterix peterix

Labels
bug infrastructure
Projects
None yet
Milestone
0.4.8
Development

No branches or pull requests
1 participant
@peterix