Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI inconsistancies when changing instance type #3720

Closed
ghost opened this issue Apr 8, 2021 · 1 comment · Fixed by #3880
Closed

UI inconsistancies when changing instance type #3720

ghost opened this issue Apr 8, 2021 · 1 comment · Fixed by #3880
Labels
bug

Comments

@ghost
Copy link

ghost commented Apr 8, 2021 •
edited by ghost
Loading

Operating System

Windows

Description of bug

MultiMC Version: 0.6.12-devlop-2055
I've noticed a few inconsistencies when changing instance type in the new instance screen. ( vanilla, import from zip, ... )
When switching to (ATLauncher / FTB / Technic) pack selection after previously selecting a pack I've observed the following:

  1. The OK button state is not updated
  2. The pack icon fails to update properly, defaults to multimc icon or stays same if switching from Curseforge / FTB Legacy, also stays the same when switching from FTB to ATLauncher.

Steps to reproduce

  1. Add Instance.
  2. Select FTB and select any pack, so that OK button is enabled.
  3. Change to any other install type, e.g. FTB Legacy. (2)
  4. Change back to FTB.
  5. OK button is disabled. (1) Icon is now MultiMC icon. (2)
  6. Select a different pack such that the instance icon updates.
  7. Switch to ATLauncher.
  8. Instance Icon is still the FTB pack icon. (2)

Suspected cause

Not sure however these issues don't seem to affect Curseforge or FTB Legacy so I would refer to them.

This issue is unique

I have searched the issue tracker and did not find an issue describing my bug.
@ghost ghost added the bug label Apr 8, 2021
@jamierocks
Copy link
Contributor

The lingering Legacy FTB icons is covered by GH-3118. Interesting about the OK button state not being updated though, will test that.

@phit phit mentioned this issue Jun 19, 2021
Merged
phit added a commit to phit/MultiMC5 that referenced this issue Jun 19, 2021
@phit
MultiMCGH-3720 Fix UI inconsistencies with Modplatforms
f7c144c 
Fixes MultiMCGH-3118
Fixes MultiMCGH-3720
Fixes MultiMCGH-3731

Icons and Ok button state will now switch consistently when moving
between tabs. ATLaunchers packlist is now no longer redownloaded
each time you open its Tab. All lists are striped now. And all
search and filter fields now have a placeholder text.
peterix added a commit that referenced this issue Jun 20, 2021
@peterix
Merge pull request #3880 from phit/fix/GH-3720
bace6fe 
GH-3720 Fix UI inconsistencies with Modplatforms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-3720 Fix UI inconsistencies with Modplatforms phit/MultiMC5
1 participant
@jamierocks