Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix node.js error on building docker image #331

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jethror1
Copy link
Contributor

@jethror1 jethror1 commented Dec 15, 2021

PR Checklist

  • This comment contains a description of changes (with reason)
  • Referenced issue is linked
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated
  • docs/changelog.md is updated

Description of changes

Switched from using node:latest to node:16.13.0 to fix #330 that caused a fail in building docker image with node.js v17.2.0

Technical details

Additional context

@jethror1
Copy link
Contributor Author

have now added newer sqlalchemy packages that I previously missed from the PR required to successfully build the image

@jethror1
Copy link
Contributor Author

Failed due to deprecation of ModelSchema in marshmallow-sqlalchemy-0.26.0: https://github.com/marshmallow-code/marshmallow-sqlalchemy/blob/03c2cfcb09992020a855a31218e91f32ebc9eb14/CHANGELOG.rst#0260-2021-05-26

Set to highest version of 0.25.1 to stop 0.26.1 being pulled when building that caused previous fail:

Collecting marshmallow-sqlalchemy~=0.25
  Downloading marshmallow_sqlalchemy-0.26.1-py2.py3-none-any.whl (15 kB)


megaqc/rest_api/schemas.py:15: in <module>
    from marshmallow_sqlalchemy.schema import ModelSchema, ModelSchemaMeta, ModelSchemaOpts
E   ImportError: cannot import name 'ModelSchema' from 'marshmallow_sqlalchemy.schema' (/opt/hostedtoolcache/Python/3.7.12/x64/lib/python3.7/site-packages/marshmallow_sqlalchemy/schema.py)
Error: Process completed with exit code 4.

@jethror1
Copy link
Contributor Author

More deprecation errors, dropped all SQL package versions back to match latest docker image from dockerhub:

root@jethro-T490:/app# pip freeze | grep -i sql
Flask-SQLAlchemy==2.4.4
marshmallow-sqlalchemy==0.24.1
SQLAlchemy==1.3.20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node.js error on building docker image
1 participant