Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-HighChart plots return an error when trying to export #1872

Closed
4 tasks done
robsyme opened this issue Mar 3, 2023 · 3 comments
Closed
4 tasks done

Non-HighChart plots return an error when trying to export #1872

robsyme opened this issue Mar 3, 2023 · 3 comments
Labels
bug: core Bug in the main MultiQC code core: front end

Comments

@robsyme
Copy link
Contributor

robsyme commented Mar 3, 2023

Description of bug

When a multiQC report include plots that are not the basic HighChart variety, plot export throws a potentially confusing error:

image

When a report contains many plots, it is difficult to track down which plot/plots are causing the issue without going through the list one by one.

I have not included a full MultiQC log as this is a front-end javascript problem. I have checked the I have included a full MultiQC log box regardless. Forgive me Phil ❤️

File that triggers the error

5_multiqc_report.html.zip

MultiQC Error log

No response

Before submitting

  • I have read the troubleshooting documentation.
  • I am using the latest release of MultiQC.
  • I have included a full MultiQC log, not truncated.
  • I have attached an input file (.zip if necessary) that triggers the error.
@ewels ewels added bug: core Bug in the main MultiQC code core: front end labels Mar 3, 2023
@ewels
Copy link
Member

ewels commented Mar 3, 2023

The alert here is not really the problem - the custom FastQC heatmap can't be exported. Fix is to not make this a blocker for exporting other plots though. Instead, alert / warn about the problem and keep going..

@ewels
Copy link
Member

ewels commented Mar 3, 2023

  • FastQC custom heatmap
  • Dragen custom heatmap
  • Table scatter plots when columns not selected

@ewels
Copy link
Member

ewels commented Sep 13, 2023

Is this fixed by #1976 @vladsavelyev ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: core Bug in the main MultiQC code core: front end
Projects
None yet
Development

No branches or pull requests

3 participants