Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor plotting JavaScript #34

Closed
ewels opened this issue Sep 23, 2015 · 0 comments
Closed

Refactor plotting JavaScript #34

ewels opened this issue Sep 23, 2015 · 0 comments
Assignees
Milestone

Comments

@ewels
Copy link
Member

ewels commented Sep 23, 2015

Merged three issues into this:

  1. Currently, if samples are hidden in the saved config, the page loads then is immediately unresponsive whilst those samples are removed.
  2. Highlight line graphs samples - save doesn't work (Highlight line graphs samples - save doesn't work #54)
  3. Speed up 'hide samples' (Speed up 'hide samples' #53)

Most of the toolbox features currently work on rendered plots - looking through existing features and changing them. Instead, it might be better to replot everything when something changes.

  • Restructure plotting functions to work off a canonical data source that doesn't change
    • Make a copy of this data at plot time
    • Get highlight / rename / hide settings from page
    • Recolour / rename / remove data from the copied data structure
    • Create plot
  • Refactor highlight / rename / hiding to call plotting functions when changed, instead of modifying directly
  • Plotting functions should not fire on page load, instead be triggered by config load.

This is sort of semi-implemented already in some places, for instance all of the code involving sample renaming. This is a fairly large refactoring, but I think that it will make the reports quite a bit more stable.

It could also lead to a potential fix for the mysterious slowness in #53, as hiding samples often seems slower than opening the page in the first time.

Finally - it should also fix #54 as the sample colouration will be set properly in the highcharts settings, so properly exported in other file formats (rather than a post-plotting hack).

@ewels ewels self-assigned this Sep 26, 2015
@ewels ewels changed the title Toolbox - hide samples before rendering page Refactor plotting JavaScript Oct 8, 2015
@ewels ewels modified the milestone: v0.3 Oct 19, 2015
@ewels ewels closed this as completed in #78 Oct 26, 2015
alexiswl pushed a commit to alexiswl/MultiQC that referenced this issue Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant