Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always save custom content data to file #1528

Merged
merged 5 commits into from
Nov 9, 2021

Conversation

ErikDanielsson
Copy link
Collaborator

@ErikDanielsson ErikDanielsson commented Aug 17, 2021

Updated custom_content to always write the data to file. I couldn't figure out how to handle heatmap data however, since it is given as a nested list rather than a dictionary. Should close #1194 eventually.

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md has been updated

@ewels
Copy link
Member

ewels commented Nov 9, 2021

I couldn't figure out how to handle heatmap data however, since it is given as a nested list rather than a dictionary

Yeah I've hit this before with heatmaps. Also some modules create more complicated data structures that don't fit into .tsv files. I think it's fine - the export works fine if using -k yaml or -k json and I've thought about saving all of these output formats anyway.

@ewels
Copy link
Member

ewels commented Nov 9, 2021

Ahh, it actually crashes with the heatmap with tsv files.. Ok then we just skip those then.

@ewels
Copy link
Member

ewels commented Nov 9, 2021

Ok and whilst this PR fixes the second part of the issue - saving the files even when not exporting the plots - it doesn't solve the first part. The random filenames. Now we get two versions of all the data when running with --export, a random filename and a nice filename..

@ewels
Copy link
Member

ewels commented Nov 9, 2021

Ok, done I think. No duplicate files for custom content now, and plot IDs set so no more random alphanumeric sequences.

@ewels ewels enabled auto-merge November 9, 2021 23:10
@ewels ewels merged commit 40a4d18 into MultiQC:master Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate custom content files for all plots, not just tables
2 participants