Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only set id for custom content when id not set by metadata #1634

Merged
merged 4 commits into from
Mar 3, 2022
Merged

Only set id for custom content when id not set by metadata #1634

merged 4 commits into from
Mar 3, 2022

Conversation

idot
Copy link
Contributor

@idot idot commented Feb 17, 2022 •
edited by ewels

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md has been updated
  • Code is tested and works locally (including with --lint flag)

Closes #1629
#1550 set the id for all custom content.
Now only when id not already in metadata

@idot idot mentioned this pull request Feb 17, 2022
Closed
ewels
ewels approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix 👍🏻

@ewels ewels merged commit e0249fb into MultiQC:master Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewels ewels ewels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DupRadar section in MultiQC report is duplicated for each sample
2 participants
@idot @ewels