Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where bclconvert always assumed paired-end reads when setting cluster-length #1701

Conversation

andrei-seleznev
Copy link
Contributor

This should resolve #1697 - we now set cluster length to read length, not read read length * 2, if we see from our RunInfo.xml that we have single-end reads.

  • [x ] This comment contains a description of changes (with reason)
  • CHANGELOG.md has been updated

Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for spotting and fixing this 👍🏻

@ewels ewels changed the base branch from master to temp_merge_branch September 9, 2022 22:41
@ewels ewels merged commit b8cab2e into MultiQC:temp_merge_branch Sep 9, 2022
@ewels ewels mentioned this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bclconvert: incorrect stats for single-read data
2 participants