-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New module: Porechop #1728
New module: Porechop #1728
Conversation
I think tests are failing possibly because it's taking too long to search for the string inside each log file... need to work out how to speed up I guess . I guess theoretically via number of lines but I'm not sure if this is consistent between porechop runs, will need to compare |
I'm tempted to combine the 3 plots into 1, with 3 datasets. Feels quite verbose for fairly simple stats. But I'll leave it for now as it's late and I should be in bed. It's an easy change if you agree though: https://multiqc.info/docs/#switching-datasets |
Thanks @ewels ! I wasn't sure what was the normal practise here, looking through other examples it looked like switching was between counts and percentages, and the percentages were calculated by the module itself and wasn't derived from the log files themselves. Therefore in this case were the percentages were in the porechop log files, I thought it better to plot each set of raw data separately - but I have no preference either way. |
I don't mean the percentages really - that bit is fine. I more meant combining the plots of the three different metrics (start, end, split) into one section / plot. Just with tabs to move between them. Each would still have counts / percentages in the same way. |
Adds module for Porechop
CHANGELOG.md
has been updated--lint
flag)docs/README.md
is updated with link to belowdocs/modulename.md
is createdself.add_section
)Example output:
multiqc_report.zip