-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New module: DIAMOND #1731
New module: DIAMOND #1731
Conversation
As with #1732 - I'm not sure that the bar plot adds anything, so I've removed it. Hope that's ok. |
@@ -272,6 +272,9 @@ deeptools/plotPCAData: | |||
deeptools/plotProfile: | |||
contents: "bin labels" | |||
num_lines: 1 | |||
diamond: | |||
contents: "type: Diamond database" | |||
fn: "*.log" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this module parse only the output from the --log
flag? https://github.com/bbuchfink/diamond/wiki/3.-Command-line-options#general-options
In which case, is the filename always diamond.log
? That's much easier (and faster) to search for..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talked to @jfy133 and it looks like this is the case. I updated the module accordingly in a489954:
- Update search pattern
- Parse sample name from logged command instead of filename
- Fall back to log directory name
Note that if you're manually renaming these log files in the taxprofiler pipeline, you'll need to tweak the search pattern in the pipeline MultiQC config file for it to still find the files. See docs.
Adds module for DIAMOND.
CHANGELOG.md
has been updated--lint
flag)docs/README.md
is updated with link to belowdocs/modulename.md
is createdself.add_section
)Example output:
multiqc_report.zip