New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New module: sourmash compare #1812
Conversation
Co-authored-by: Vlad Savelyev <vladislav.sav@gmail.com>
…e_data_file, capitalise labels
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for writing this module!
I made some refactoring, mainly:
- the extra compare2matrix felt like an unnecessary abstraction
- simplified parsing -
data.tolist()
is extactly the inputheatmap.plot
expects, so no need to go through an extra intermediate dict (and in the future, we should even be able to use numpy arrays directly without extra copying!) - minor clean up and uncommenting
self.write_data_file()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of very small comments, but generally looks great and happy for this to be merged once those are addressed 👍🏻
This PR adds a new multiqc module for the output of sourmash compare (#1805). It was modeled after the vcftools relatedness2 module. I left space for future sourmash modules that I will implement soon.
CHANGELOG.md
has been updatedNew module checklist:
--lint
flag)docs/README.md
is updated with link to belowdocs/modulename.md
is createdself.add_section
)Test data:
This test data is two files, the
*labels.txt
file and the numpy array that is output alongside thelabels.txt
document. I've zipped them together to allow for upload to the PR, but they should be unzipped and uploaded as separate files to the https://github.com/ewels/MultiQC_TestData repository.gut_compare.zip