Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dragen coverage metrics to show target bed and qc coverage metrics #1854

Merged

Conversation

alexiswl
Copy link
Contributor

@alexiswl alexiswl commented Feb 2, 2023

Refactored parse_wgs_coverage_metrics to generic parse_coverage_metrics.

Fixes #1844

  • Target bed, qc region and wgs qc then call parse_coverage_metrics each with different parameters.
  • Fixed search patterns to include target bed coverage metrics and qc region coverage metrics.

Example outputs

QC metrics and target metrics are the same since I used the same bed file as input for both.

wgs_with_qc_region.html.gz
target_with_qc_region.html.gz

Refactored parse_wgs_coverage_metrics to generic parse_coverage_metrics.  

Fixes MultiQC#1844

Target bed, qc region and wgs qc then call parse_coverage_metrics each with different parameters.  

 Fixed search patterns to include target bed coverage metrics and qc region coverage metrics.
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not my favourite MultiQC module, but tested locally and seemed to work and a read over of the code looks sensible.

Thanks!

@ewels ewels merged commit be99c67 into MultiQC:master Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dragen: v1.14 no longer looks for .bed files for coverage metrics
2 participants