Conpair concordance: account for different format when run with --outfile
#1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the PR looks great. It would be nice to add tests for this into https://github.com/ewels/MultiQC_TestData, it should be good to merge? |
vladsavelyev
added
awaits-review
vladsavelyev
added a commit
to MultiQC/test-data
that referenced
this pull request
Aug 30, 2023
vladsavelyev
added a commit
to MultiQC/test-data
that referenced
this pull request
Aug 30, 2023
Conpair: add test example for MultiQC/MultiQC#1855
vladsavelyev
changed the title
--outfile
ewels
reviewed
Aug 30, 2023
| if match: | ||
| parsed_data[k] = float(match.group(1)) | ||
| if k == "concordance_concordance" and not "Concordance" in r: | ||
| parsed_data[k] = 100 * parsed_data[k] |
There was a problem hiding this comment.
Force float variable type, otherwise we get weird integer problems..
Suggested change
| parsed_data[k] = 100 * parsed_data[k] | |
| parsed_data[k] = 100.0 * float(parsed_data[k]) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
conpair/concordanceto match with all types of Conpair outputs.conpair.pymodule to parse concordance metrics from all types of Conpair outputs.CHANGELOG.mdhas been updated