Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix critical issue with HUMID module #1857

Merged
merged 7 commits into from
Feb 6, 2023
Merged

Fix critical issue with HUMID module #1857

merged 7 commits into from
Feb 6, 2023

Conversation

Redmar-van-den-Berg
Copy link
Contributor

See #1856 for details.

@Redmar-van-den-Berg
Return data when the sanity check passes
fc96e81 
Fix issue-1856, which was caused by the fact that the process_stats
function did not return anything on success, causing the data to be
discarded.
@Redmar-van-den-Berg
Update changelog
e6110e7
ewels
ewels requested changes Feb 6, 2023
View reviewed changes
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Module needs a bit more refactoring to clean up functions outside object.

multiqc/modules/humid/humid.py Outdated Show resolved Hide resolved
@ewels
Copy link
Member

ewels commented Feb 6, 2023

I can try to have a go at the changes later if I get a moment (and if you don't beat me to it 👍🏻 )

@Redmar-van-den-Berg
Copy link
Contributor Author

I've refactored the code a bit more, hopefully it is clearer now.

ewels
ewels approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did my own minor refactoring, hope that's ok... Mostly a personal taste thing, but I find this a little less complex (no copying / passing dicts around) and easier to read / maintain.

Thanks for the fix! ✨

@ewels ewels merged commit 24b885f into MultiQC:master Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewels ewels ewels approved these changes

Assignees
No one assigned
Labels
priority: high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Redmar-van-den-Berg @ewels