New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qualimap: BamQC: add percentage on target #2020
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Looks good to me.
I think it make sense to change the title of the existing regions_mapped_reads
metric from "{} Aligned"
to "{} On target"
, otherwise it has the same name as the overall number of mapped reads.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just rename the regions_mapped_reads
metric from "{} Aligned" to "{} On target", please :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Couple of minor pedantic comments, will fix quickly myself now.
I realised that several of my review comments also applied to existing code within the module! So was a good opportunity to clean those bits up as well ✅ Many thanks for this @FerriolCalvet! |
Solving this issue: #2019
This comment contains a description of changes (with reason)
This is explained in the issue referenced above. But basically I am adding an extra column to the output table of Qualimap BAMQC. This value is already present in the default output of Qualimap BAMQC. It is the (97.14%).
CHANGELOG.md
has been updated