-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xenome: show percentages by default, add table and sections #2164
Conversation
🚀 Deployed on https://mqc-pr-2164--multiqc.netlify.app |
Thanks a ton @vladsavelyev for working on this. |
@vladsavelyev One suggestion - to add to the multiqc docs for xenome
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM to merge after the suggested docs additions are made 👍🏻
@vladsavelyev is this available in a dev version that I can try out after installing with pip like this?
|
@tamuanand, after the PR is merged - yes. Before that, you would need to specify the branch name as well: pip install --upgrade --force-reinstall git+https://github.com/ewels/MultiQC.git@xenome If you do it often though, it's convenient to keep a clone of the repo locally: git clone https://github.com/ewels/MultiQC.git And run You can optionally check out a specific branch: cd MultiQC
git checkout xenome And you installation will switch into it automatically without need to do |
Few adjustments to the Xenome module based on the feedback from @tamuanand (including #1860 (comment))
Added a summary table in addition to the general stats columns. Added there hidden columns for read counts.
Properly added section wrappers to the plots to make sure they appear in the contents panel.
Additionally, making sure that the color scales for species in the table match the colors in the bar plot.