Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kraken: fix UnboundLocalError #2230

Merged
merged 4 commits into from
Dec 15, 2023
Merged

Kraken: fix UnboundLocalError #2230

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
64427c9
Kraken: fix `UnboundLocalError`
vladsavelyev Dec 14, 2023
7aa0818
[automated] Update CHANGELOG.md
multiqc-bot Dec 14, 2023
c784742
Merge branch 'master' into kraken-fix
vladsavelyev Dec 14, 2023
ae75615
Debug log message
ewels Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@

- **deepTools**: Handle missing data in plotProfile ([#2229](https://github.com/ewels/MultiQC/pull/2229))
- **GATK**: square the BaseRecalibrator scatter plot ([#2189](https://github.com/ewels/MultiQC/pull/2189))
- **Kraken**: fix `UnboundLocalError` ([#2230](https://github.com/ewels/MultiQC/pull/2230))
- **kraken**: fixed column keys in genstats ([#2205](https://github.com/ewels/MultiQC/pull/2205))
- **QualiMap**: BamQC: fix for global-only stats ([#2207](https://github.com/ewels/MultiQC/pull/2207))

Expand Down
3 changes: 1 addition & 2 deletions multiqc/modules/kraken/kraken.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,12 +446,11 @@ def top_taxa_duplication_heatmap(self):
try:
sorted_pct = sorted(self.kraken_total_pct[rank_code].items(), key=lambda x: x[1], reverse=True)
except KeyError:
pass
# Taxa rank not found in this sample
return
ewels marked this conversation as resolved.
Show resolved Hide resolved

i = 0
counts_shown = {}

showed_warning = False
for classif, pct_sum in sorted_pct:
i += 1
Expand Down