Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qualimap: address NBSP as thousand separators #2282

Merged
merged 10 commits into from Feb 6, 2024
Merged

Qualimap: address NBSP as thousand separators #2282

merged 10 commits into from Feb 6, 2024

Conversation

vladsavelyev
Copy link
Member

@vladsavelyev vladsavelyev commented Jan 24, 2024 •
edited

Fix #1870

Refactor to determine decimal format once per file. Optimize to call regex only one per line.

@vladsavelyev vladsavelyev added bug: module Bug in a MultiQC module awaits-review Awaiting final review and merge. labels Jan 24, 2024
@vladsavelyev vladsavelyev added this to the MultiQC v1.20 milestone Jan 24, 2024
@vladsavelyev vladsavelyev changed the title Qualimap: address NBSP as thousand separators in rnaseqqc Qualimap: address NBSP as thousand separators Jan 25, 2024
@vladsavelyev vladsavelyev mentioned this pull request Jan 25, 2024
Closed
4 tasks
ewels
ewels approved these changes Feb 3, 2024
View reviewed changes
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Surprisingly complex! I wonder if we can move this to a central helper function to share across other modules, but suggest that we only do that another day if we come across similar code and feel like it.

multiqc/modules/qualimap/QM_RNASeq.py Show resolved Hide resolved
multiqc/modules/qualimap/__init__.py Outdated Show resolved Hide resolved
@ewels ewels removed the awaits-review Awaiting final review and merge. label Feb 3, 2024
@vladsavelyev vladsavelyev merged commit 41c0228 into main Feb 6, 2024
3 checks passed
@vladsavelyev vladsavelyev deleted the qualimap-fix branch February 6, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewels ewels ewels approved these changes

Assignees
No one assigned
Labels
bug: module Bug in a MultiQC module
Projects
None yet
Milestone
MultiQC v1.20: Plotly
Development

Successfully merging this pull request may close these issues.

Qualimap RNAseq locale parsing error
3 participants
@vladsavelyev @ewels @multiqc-bot