Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export config.output_dir in MegaQC JSON #2287

Merged
merged 8 commits into from Feb 1, 2024
Merged

Conversation

fgvieira
Copy link
Contributor

@fgvieira fgvieira commented Jan 31, 2024

Add output_dir to JSON as an absolute path, so it can be used in MultiQC/MegaQC#22.

@fgvieira fgvieira changed the title feat: JSON cwd feat: JSON output dir Feb 1, 2024
@fgvieira fgvieira changed the title feat: JSON output dir feat: store output dir on JSON Feb 1, 2024
@vladsavelyev vladsavelyev changed the title feat: store output dir on JSON Export config.output_dir in MegaQC JSON Feb 1, 2024
@vladsavelyev vladsavelyev added core: back end awaits-review Awaiting final review and merge. labels Feb 1, 2024
@vladsavelyev vladsavelyev added this to the MultiQC v1.20 milestone Feb 1, 2024
@vladsavelyev vladsavelyev self-requested a review February 1, 2024 17:54
@vladsavelyev
Copy link
Member

@multiqc-bot changelog

Copy link
Member

@vladsavelyev vladsavelyev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@vladsavelyev vladsavelyev merged commit 57f60ab into MultiQC:main Feb 1, 2024
6 checks passed
@fgvieira fgvieira deleted the json_cwd branch February 2, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaits-review Awaiting final review and merge. core: back end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants