Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group-mode bar plot: fix inner gap #2321

Merged
merged 4 commits into from Feb 13, 2024
Merged

Group-mode bar plot: fix inner gap #2321

merged 4 commits into from Feb 13, 2024

Conversation

vladsavelyev
Copy link
Member

When adding each sample to the bar graph as a separate trace, when the barmode is group the Plotly adds a giant gap between the inner bars:

Screenshot 2024-02-12 at 17 44 41

Since the group mode is not used often, we can sacrifice dimming the de-highlighted bars and leave the trace labels as a highlight marker alone:

Screenshot 2024-02-12 at 17 46 31

@vladsavelyev vladsavelyev added the awaits-review Awaiting final review and merge. label Feb 12, 2024
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ewels ewels merged commit ec4c485 into main Feb 13, 2024
6 checks passed
@ewels ewels deleted the group-bar-gap branch February 13, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaits-review Awaiting final review and merge. core: front end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants