Plot categories refactoring #2418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vladsavelyev
commented
Mar 3, 2024
vladsavelyev
commented
- Keep line plot categories a boolean throughout the code, and data points as pairs for simplicity.
- Set scatter plot categories as tick labels, keeping the x values float.
vladsavelyev
added a commit
that referenced
this pull request
Mar 10, 2024
* Remove highcharts template * Remove highcarts in pyproject * Remove/rename highchart-styled CamelCased options * [automated] Update CHANGELOG.md * Replace calls of beeswarm with violin * Remove marker: enabled: False * Remove Nones from line configuration * rseqc: remove highchart javascript custom stuff * Remove remaining Highcharts and matplotlib references * More screenshots update * Geo fix? * Fix min_range -> minrange * Fix CSP * Bcftools: x_decimals instead of xDecimals; counts are ints * Fix groupped barplot minallowed calculation * Bar plot fix rgba->rgb * Shorter axis labels from hoverformat * ylab_format -> ysuffix * Fix maxaallowd for barplots * Allow having required pconfig fields in data_labels * More module suffixes and formatting fixes * Only parse set of predetermined suffixes from tt_label * max/clipmax for scatter plots * Set spaces for expicitly provided xsuffix/ysuffix * Update more modules * Remove confusing % tab in mosdepth XY barplot * Module fixes * Set width for plot zoom in docs * More auto-suffixes * Keep lineplot category property boolean, and data point a pair for simplicity * Fix scatter plot categories * [automated] Update CHANGELOG.md * More modules * More modules * Fix x-axis log scale setting for line plots with bands * CSP * Fix linting * CSP * Rename x back to k * More bp suffixes --------- Co-authored-by: MultiQC Bot <multiqc-bot@seqera.io>
vladsavelyev
added a commit
that referenced
this pull request
Mar 14, 2024
* QualiMap BamQC trimming long taili keep at least 20x * [automated] Update CHANGELOG.md * Disable CSP linting, keep the script for users to run manually (#2421) * Violin plot export: use metric titles instead of IDs * Add Export button for table. Do not prefix violin ID, instead prefix table. * Violin save_data_file: use titles instead of metric ids as well * [automated] Update CHANGELOG.md * Fix * Avoid in tables * Fix linting * Unnecessary nowrap * Use a small space span before suffix * [automated] Update CHANGELOG.md * Also replace with a space in case if modules set it * changelog * Fix linting * CSP * Update clipboard.js * Different name of clipboard constructor * [automated] Update CHANGELOG.md * CSP * Fix * CSP * CSP * CSP * Add plot headers * CSP to contain only current scripts * Update js headers for better CSP snippets * update CSP * Header for /multiqc_rseqc.js * Update headers * Update CSP * Update CSP in the CI job * [automated] Update CHANGELOG.md * Revert * Pass tocken to checkout * Separate CI job and find JS files in the codebase instead of parsing the file * Rename headers * Fix * JS headers * Wording * Update .github/workflows/csp.yml Co-authored-by: Luka Jeran <lukaw3d@gmail.com> * Add scripts/csp.py script to generate a whitelist, do not automate * Rename * Remove GH automation * Changelog * Use old script name * Revert script headers * Document taht beautifulsoup4 is needed --------- Co-authored-by: MultiQC Bot <multiqc-bot@seqera.io> Co-authored-by: Luka Jeran <lukaw3d@gmail.com> * Remove Highcharts and Matplotlib (#2409) * Remove highcharts template * Remove highcarts in pyproject * Remove/rename highchart-styled CamelCased options * [automated] Update CHANGELOG.md * Replace calls of beeswarm with violin * Remove marker: enabled: False * Remove Nones from line configuration * rseqc: remove highchart javascript custom stuff * Remove remaining Highcharts and matplotlib references * More screenshots update * Geo fix? * Fix min_range -> minrange * Fix CSP * Bcftools: x_decimals instead of xDecimals; counts are ints * Fix groupped barplot minallowed calculation * Bar plot fix rgba->rgb * Shorter axis labels from hoverformat * ylab_format -> ysuffix * Fix maxaallowd for barplots * Allow having required pconfig fields in data_labels * More module suffixes and formatting fixes * Only parse set of predetermined suffixes from tt_label * max/clipmax for scatter plots * Set spaces for expicitly provided xsuffix/ysuffix * Update more modules * Remove confusing % tab in mosdepth XY barplot * Module fixes * Set width for plot zoom in docs * More auto-suffixes * More modules * CSP * More bp suffixes * Docs: use markdown instead of <img> for iamges? * Screenshot size * Reoder changelog --------- Co-authored-by: MultiQC Bot <multiqc-bot@seqera.io> * Plot categories refactoring (#2418) * Remove highcharts template * Remove highcarts in pyproject * Remove/rename highchart-styled CamelCased options * [automated] Update CHANGELOG.md * Replace calls of beeswarm with violin * Remove marker: enabled: False * Remove Nones from line configuration * rseqc: remove highchart javascript custom stuff * Remove remaining Highcharts and matplotlib references * More screenshots update * Geo fix? * Fix min_range -> minrange * Fix CSP * Bcftools: x_decimals instead of xDecimals; counts are ints * Fix groupped barplot minallowed calculation * Bar plot fix rgba->rgb * Shorter axis labels from hoverformat * ylab_format -> ysuffix * Fix maxaallowd for barplots * Allow having required pconfig fields in data_labels * More module suffixes and formatting fixes * Only parse set of predetermined suffixes from tt_label * max/clipmax for scatter plots * Set spaces for expicitly provided xsuffix/ysuffix * Update more modules * Remove confusing % tab in mosdepth XY barplot * Module fixes * Set width for plot zoom in docs * More auto-suffixes * Keep lineplot category property boolean, and data point a pair for simplicity * Fix scatter plot categories * [automated] Update CHANGELOG.md * More modules * More modules * Fix x-axis log scale setting for line plots with bands * CSP * Fix linting * CSP * Rename x back to k * More bp suffixes --------- Co-authored-by: MultiQC Bot <multiqc-bot@seqera.io> * Do not maintain change log between releases (#2427) * Build change log on release * [automated] Update CHANGELOG.md * Add .github/changelog.py and update checklist * Remove old changelog * Checkout back to main * Move to scripts * Rename to print_changelog.py --------- Co-authored-by: MultiQC Bot <multiqc-bot@seqera.io> * Changelog --------- Co-authored-by: MultiQC Bot <multiqc-bot@seqera.io> Co-authored-by: Luka Jeran <lukaw3d@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.