Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastp: test data with --in1 command, as well as with broken command #295

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

vladsavelyev
Copy link
Member

Adding test data for MultiQC/MultiQC#2139

  • Examples from MultiQC 1.17 fails to recognize fastp files MultiQC#2138 that use --in1 as a command: "command": "fastp --in1 HG001_1.fastq.gz --in2 HG001_2.fastq.gz --out1 HG001_1.trim.fastq.gz --out2 HG001_2.trim.fastq.gz --json HG001.fastp.json --html HG001.fastp.html --report_title HG001 fastp report --thread 16 --detect_adapter_for_pe "
  • An example with a completely broken command to test that we fall back to using the file name as a sample name correctly.

@vladsavelyev vladsavelyev merged commit 46c8dce into master Oct 19, 2023
@ewels ewels deleted the fastp-fallback-fname branch December 18, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant