Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to new hybrid rendering mode #55

Merged
merged 2 commits into from May 26, 2023
Merged

Switch to new hybrid rendering mode #55

merged 2 commits into from May 26, 2023

Conversation

ewels
Copy link
Member

@ewels ewels commented May 22, 2023

Released in Astro v2.5

@netlify
Copy link

netlify bot commented May 22, 2023

Deploy Preview for multiqc ready!

Name Link
🔨 Latest commit 0d253f8
🔍 Latest deploy log https://app.netlify.com/sites/multiqc/deploys/646b7495fd76980008a4c8e9
😎 Deploy Preview https://deploy-preview-55--multiqc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ewels
Copy link
Member Author

ewels commented May 22, 2023

❌ Getting a 404 on any pages with a dynamic path.

npm run dev also fails for these pages:

09:57:38 AM [getStaticPaths] getStaticPaths() in src/pages/docs/[...slug].astro is ignored when "output: server" is set.

Released in Astro v2.5
@ewels
Copy link
Member Author

ewels commented May 22, 2023

Looks like I'm hitting this bug. There's a fix in the works, so just need to wait for a new patch release.

@ewels ewels marked this pull request as draft May 22, 2023 08:18
@ewels ewels marked this pull request as ready for review May 26, 2023 18:22
@ewels ewels merged commit ef4820b into main May 26, 2023
5 checks passed
@ewels ewels deleted the hybrid-rendering branch May 26, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant