Feature/12 #38
Feature/12 #38
Conversation
There was a problem hiding this comment.
Great job a few functional comments (Mainly surrounding the form validation)
But otherwise looking really good Great job @louisan42 ,
Let me know if you need any help from me fixing any of these comments / want me to apply any of the fixes myself 👍
| helperText={ | ||
| <StyledFormHelperText id="main-text-font-helper-text"> | ||
| {formik.touched.mainTextFont && | ||
| formik.errors.mainTextFont} |
There was a problem hiding this comment.
The errors for this do not seem to work for some reason Select the main text font. I wonder if formik.touched.mainTextFont has not been set given if you try and submit the form with these empty no error ever appears. The form is just submittable with feels a little odd
| await updateDoc(docRef,{ userPreferences: values }); | ||
| navigate("/"); | ||
| } catch (e) { | ||
| console.error(e); |
There was a problem hiding this comment.
Might be worth dropping a https://mui.com/material-ui/react-alert/ just reporting that an error occurred on error
| systemName: "", | ||
| twoFactAuth: false, | ||
| }, | ||
| validationSchema: accountSetupSchema, |
There was a problem hiding this comment.
For some reson schema validation errors do not seem to be appearing in the formik error text. Let me know if you want a quick chat / for us to pair up and look into this
| <Page showSideBar={false}> | ||
| <CustomContainer> | ||
| <Box sx={{ padding: "50px 100px" }}> | ||
| <Box sx={{ textAlign: "center", paddingBottom: "3rem" }}> |
There was a problem hiding this comment.
It might be worth dropping the font size on smaller view ports in order to allow for smaller mobile clients to see the page.
| }); | ||
|
|
||
| //Define options to pass to custom select component | ||
| const headerOptions = [ |
There was a problem hiding this comment.
Thease can probably be defined outside the the component so we do not have to redefine them on rerender
feature 12: init code clean up after review Co-authored-by: ryanolee <landgraabiv@gmail.com>
feature 12: clear spacing and commented lines Co-authored-by: ryanolee <landgraabiv@gmail.com>
|
@louisan42 I might extract the "Custom" components into another PR and rebase this one onto that one so that we can begin using the form components made here sooner 👍 |
What
Adds sign in page and account setup pages
Why
This adds a core feature to the application
How
By creating a sign in page using google sign in and an account setup page which will serve as a global config for registered users.
Covers
#12
Checklist
Screenshots
Desktop view
Mobile view