Optionally generate build_report.json #38
Conversation
|
This pull request has been linked to Shortcut Story #27167: Extend build pipeline to gather stats on failure reason. |
…line-to-gather-stats-on
| --ra | ||
| --stats | ||
| """ | ||
| def incompatible_args_error do |
There was a problem hiding this comment.
json-report cannot be set with debug.
say that here
| @@ -0,0 +1,17 @@ | |||
| defmodule BuildPipeline.Run.JsonReport do | |||
There was a problem hiding this comment.
write a test that at this level that asserts a file gets written?
use Mimic to not actually write a file?
I'm open to you saying "nah, i dont think its needed"
There was a problem hiding this comment.
but thats what I'd do I think
| @@ -123,6 +135,10 @@ defmodule BuildPipeline.Run.CommandLineArguments do | |||
| {:ok, Map.put(setup, :show_stats, true)} | |||
| end | |||
|
|
|||
| defp put_setup_from_singular_cli_arg(setup, @json_report) do | |||
There was a problem hiding this comment.
I've TDD'd adding a new command line arg by adding a high level test
either at the server_test or run_test (cant remember which) level.
Add such a high level test for json report?
I'm open to pushback on this, but that is how I added all the other CLI args anyhow
Adds a
--json-reportflag which can be used to generate a json report which looks something like this:{ "steps": [ { "build_step_name": "MIX_ENV=dev mix compile", "duration_in_microseconds": 627731, "exit_code": 0, "status": "complete" }, { "build_step_name": "MIX_ENV=dev mix escript.build", "duration_in_microseconds": 790919, "exit_code": 0, "status": "complete" }, { "build_step_name": "MIX_ENV=test mix compile --force --warnings-as-errors", "duration_in_microseconds": 1082262, "exit_code": 0, "status": "complete" }, { "build_step_name": "end_to_end_test", "duration_in_microseconds": 1194515, "exit_code": 0, "status": "complete" }, { "build_step_name": "escriptBuild", "duration_in_microseconds": 900716, "exit_code": 0, "status": "complete" }, { "build_step_name": "exit_code_correctness_end_to_end_test", "duration_in_microseconds": 301516, "exit_code": 0, "status": "complete" }, { "build_step_name": "find_todos", "duration_in_microseconds": 19252, "exit_code": 0, "status": "complete" }, { "build_step_name": "mix deps.get", "duration_in_microseconds": 1161638, "exit_code": 0, "status": "complete" }, { "build_step_name": "mix loadconfig config/prod.exs", "duration_in_microseconds": 620232, "exit_code": 0, "status": "complete" }, { "build_step_name": "mix test --color", "duration_in_microseconds": 1286466, "exit_code": 0, "status": "complete" }, { "build_step_name": "preflight_checks_return_non_zero_exit_code_test", "duration_in_microseconds": 232673, "exit_code": 0, "status": "complete" } ] }Test by running:
MIX_ENV=prod mix escript.build