/mv clone command

[mathphreak]

Adding /mv clone per #779

[fernferret]

Brief read is looking good, will test on or before this weekend and pull, thanks!

[mathphreak]

My code doesn't copy over world properties set with /mv modify, and I can't figure out how to copy those in bulk, but it shouldn't be too hard.

[fernferret]

Ideally it would just make an in memory copy of one of the MVWorld objects, then save that object to disk (yaml).

EDIT: In addition to what you're doing with the filesystem.

[dumptruckman]

Before we pull this I'd like to see the file copy method moved from Multiverse-Adventure's FileUtil to cores.

[dumptruckman]

And here it is: 085c7a1
Please work with the new code base. Make sure to "git pull -r" to replay your commits on top of the new codebase and avoid a nasty merge message.

[dumptruckman]

Hmm, and it would appear if you use our method you'll have to delete the uid.dat afterwards. I still think that would be the better course of action.

[fernferret]

Maybe modifying the utils method to allow deletion of the uid as a parameter?

[mathphreak]

Now using FileUtils.copyFolder().

[main--]

Wrong indentation

[fernferret]

Sorry @mathphreak had a busy weekend (read: slacker playing the Guild Wars 2 beta...) I'll see about looking at it sometime this week, won't be tonight. It looks as if @main-- and @dumptruckman have already given their input, and you've fixed all they've asked.

[dumptruckman]

So... After more careful review I've decided that the world copy will have to be asynchronous or else copying a huge world folder will lag out your server. As a side effect of being asynchronous, you would have to kick everyone out of the fromWorld and unload it BEFORE you copy it. Since this is kind of a "what???" procedure, it would probably be best to require and /mvconfirm first that warns them what is going to happen.

[mathphreak]

As a side effect of requiring /mvconfirm, I've had to move the cloning logic from CloneCommand to WorldManager. But that's probably a better place for it anyways.

[fernferret]

Nice move @mathphreak I agree entirely. We try to keep a lot of the logic out of the actual command class as it keeps those cleaner.

I'll look at it tonight or tomorrow; test and pull.

[fernferret]

Also @main-- I appreciate your critique of tabbing, but I'll just have IntelliJ zap all the imported files :P

[fernferret]

What's this @mathphreak? I'm actually looking at this PR now?!?! Blasphemy! Seriously. Sorry for the delay.

• Slight issue with the clone command help formatting,
• Added alias /mvcl and /mv cl for the command.

More to come as I continue to test and merge.

[fernferret]

Overall, works great!

[fernferret]

Merged in f574681. Closes #779. Thanks!