Skip to content

Commit

Permalink
clippy: Fix warnings in components/script/dom/request.rs (servo#31867)
Browse files Browse the repository at this point in the history
  • Loading branch information
@Aaryakhandelwal @MunishMummadi
Aaryakhandelwal authored and MunishMummadi committed Mar 29, 2024
1 parent 3b1ea9c commit 3a1530a
Showing 1 changed file with 38 additions and 38 deletions.
76 changes: 38 additions & 38 deletions components/script/dom/request.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ impl Request {
// Step 14
if let Some(init_referrer) = init.referrer.as_ref() {
// Step 14.1
let ref referrer = init_referrer.0;
let referrer = &init_referrer.0;
// Step 14.2
if referrer.is_empty() {
request.referrer = NetTraitsRequestReferrer::NoReferrer;
Expand Down Expand Up @@ -501,7 +501,7 @@ fn is_forbidden_method(m: &ByteString) -> bool {

// https://fetch.spec.whatwg.org/#cors-safelisted-method
fn is_cors_safelisted_method(m: &HttpMethod) -> bool {
m == &HttpMethod::GET || m == &HttpMethod::HEAD || m == &HttpMethod::POST
m == HttpMethod::GET || m == HttpMethod::HEAD || m == HttpMethod::POST
}

// https://url.spec.whatwg.org/#include-credentials
Expand Down Expand Up @@ -666,9 +666,9 @@ impl BodyMixin for Request {
}
}

impl Into<NetTraitsRequestCache> for RequestCache {
fn into(self) -> NetTraitsRequestCache {
match self {
impl From<RequestCache> for NetTraitsRequestCache {
fn from(cache: RequestCache) -> Self {
match cache {
RequestCache::Default => NetTraitsRequestCache::Default,
RequestCache::No_store => NetTraitsRequestCache::NoStore,
RequestCache::Reload => NetTraitsRequestCache::Reload,
Expand All @@ -679,9 +679,9 @@ impl Into<NetTraitsRequestCache> for RequestCache {
}
}

impl Into<RequestCache> for NetTraitsRequestCache {
fn into(self) -> RequestCache {
match self {
impl From<NetTraitsRequestCache> for RequestCache {
fn from(cache: NetTraitsRequestCache) -> Self {
match cache {
NetTraitsRequestCache::Default => RequestCache::Default,
NetTraitsRequestCache::NoStore => RequestCache::No_store,
NetTraitsRequestCache::Reload => RequestCache::Reload,
Expand All @@ -692,29 +692,29 @@ impl Into<RequestCache> for NetTraitsRequestCache {
}
}

impl Into<NetTraitsRequestCredentials> for RequestCredentials {
fn into(self) -> NetTraitsRequestCredentials {
match self {
impl From<RequestCredentials> for NetTraitsRequestCredentials {
fn from(credentials: RequestCredentials) -> Self {
match credentials {
RequestCredentials::Omit => NetTraitsRequestCredentials::Omit,
RequestCredentials::Same_origin => NetTraitsRequestCredentials::CredentialsSameOrigin,
RequestCredentials::Include => NetTraitsRequestCredentials::Include,
}
}
}

impl Into<RequestCredentials> for NetTraitsRequestCredentials {
fn into(self) -> RequestCredentials {
match self {
impl From<NetTraitsRequestCredentials> for RequestCredentials {
fn from(credentials: NetTraitsRequestCredentials) -> Self {
match credentials {
NetTraitsRequestCredentials::Omit => RequestCredentials::Omit,
NetTraitsRequestCredentials::CredentialsSameOrigin => RequestCredentials::Same_origin,
NetTraitsRequestCredentials::Include => RequestCredentials::Include,
}
}
}

impl Into<NetTraitsRequestDestination> for RequestDestination {
fn into(self) -> NetTraitsRequestDestination {
match self {
impl From<RequestDestination> for NetTraitsRequestDestination {
fn from(destination: RequestDestination) -> Self {
match destination {
RequestDestination::_empty => NetTraitsRequestDestination::None,
RequestDestination::Audio => NetTraitsRequestDestination::Audio,
RequestDestination::Document => NetTraitsRequestDestination::Document,
Expand All @@ -735,9 +735,9 @@ impl Into<NetTraitsRequestDestination> for RequestDestination {
}
}

impl Into<RequestDestination> for NetTraitsRequestDestination {
fn into(self) -> RequestDestination {
match self {
impl From<NetTraitsRequestDestination> for RequestDestination {
fn from(destination: NetTraitsRequestDestination) -> Self {
match destination {
NetTraitsRequestDestination::None => RequestDestination::_empty,
NetTraitsRequestDestination::Audio => RequestDestination::Audio,
NetTraitsRequestDestination::Document => RequestDestination::Document,
Expand All @@ -763,9 +763,9 @@ impl Into<RequestDestination> for NetTraitsRequestDestination {
}
}

impl Into<NetTraitsRequestMode> for RequestMode {
fn into(self) -> NetTraitsRequestMode {
match self {
impl From<RequestMode> for NetTraitsRequestMode {
fn from(mode: RequestMode) -> Self {
match mode {
RequestMode::Navigate => NetTraitsRequestMode::Navigate,
RequestMode::Same_origin => NetTraitsRequestMode::SameOrigin,
RequestMode::No_cors => NetTraitsRequestMode::NoCors,
Expand All @@ -774,9 +774,9 @@ impl Into<NetTraitsRequestMode> for RequestMode {
}
}

impl Into<RequestMode> for NetTraitsRequestMode {
fn into(self) -> RequestMode {
match self {
impl From<NetTraitsRequestMode> for RequestMode {
fn from(mode: NetTraitsRequestMode) -> Self {
match mode {
NetTraitsRequestMode::Navigate => RequestMode::Navigate,
NetTraitsRequestMode::SameOrigin => RequestMode::Same_origin,
NetTraitsRequestMode::NoCors => RequestMode::No_cors,
Expand All @@ -790,9 +790,9 @@ impl Into<RequestMode> for NetTraitsRequestMode {

// TODO
// When whatwg/fetch PR #346 is merged, fix this.
impl Into<MsgReferrerPolicy> for ReferrerPolicy {
fn into(self) -> MsgReferrerPolicy {
match self {
impl From<ReferrerPolicy> for MsgReferrerPolicy {
fn from(policy: ReferrerPolicy) -> Self {
match policy {
ReferrerPolicy::_empty => MsgReferrerPolicy::NoReferrer,
ReferrerPolicy::No_referrer => MsgReferrerPolicy::NoReferrer,
ReferrerPolicy::No_referrer_when_downgrade => {
Expand All @@ -810,9 +810,9 @@ impl Into<MsgReferrerPolicy> for ReferrerPolicy {
}
}

impl Into<ReferrerPolicy> for MsgReferrerPolicy {
fn into(self) -> ReferrerPolicy {
match self {
impl From<MsgReferrerPolicy> for ReferrerPolicy {
fn from(policy: MsgReferrerPolicy) -> Self {
match policy {
MsgReferrerPolicy::NoReferrer => ReferrerPolicy::No_referrer,
MsgReferrerPolicy::NoReferrerWhenDowngrade => {
ReferrerPolicy::No_referrer_when_downgrade
Expand All @@ -829,19 +829,19 @@ impl Into<ReferrerPolicy> for MsgReferrerPolicy {
}
}

impl Into<NetTraitsRequestRedirect> for RequestRedirect {
fn into(self) -> NetTraitsRequestRedirect {
match self {
impl From<RequestRedirect> for NetTraitsRequestRedirect {
fn from(redirect: RequestRedirect) -> Self {
match redirect {
RequestRedirect::Follow => NetTraitsRequestRedirect::Follow,
RequestRedirect::Error => NetTraitsRequestRedirect::Error,
RequestRedirect::Manual => NetTraitsRequestRedirect::Manual,
}
}
}

impl Into<RequestRedirect> for NetTraitsRequestRedirect {
fn into(self) -> RequestRedirect {
match self {
impl From<NetTraitsRequestRedirect> for RequestRedirect {
fn from(redirect: NetTraitsRequestRedirect) -> Self {
match redirect {
NetTraitsRequestRedirect::Follow => RequestRedirect::Follow,
NetTraitsRequestRedirect::Error => RequestRedirect::Error,
NetTraitsRequestRedirect::Manual => RequestRedirect::Manual,
Expand Down

0 comments on commit 3a1530a

Please sign in to comment.