clippy: Fix warnings in components/script/dom/request.rs
#31867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrobinson
reviewed
Mar 26, 2024
components/script/dom/request.rs
Outdated
Comment on lines
669
to
671
| impl From<RequestCache> for NetTraitsRequestCache { | ||
| fn from(val: RequestCache) -> Self { | ||
| match val { |
There was a problem hiding this comment.
Suggested change
| impl From<RequestCache> for NetTraitsRequestCache { | |
| fn from(val: RequestCache) -> Self { | |
| match val { | |
| impl From<RequestCache> for NetTraitsRequestCache { | |
| fn from(value: RequestCache) -> Self { | |
| match value { |
There was a problem hiding this comment.
I've gone ahead and made these changes.
There was a problem hiding this comment.
Apologies, I was preoccupied with some personal work and couldn't attend to the changes requested.
Thank you for making the commit.
There was a problem hiding this comment.
No worries. Thank you for the contribution!
mrobinson
requested changes
Mar 26, 2024
mrobinson
approved these changes
Mar 27, 2024
ektuu
pushed a commit
to ektuu/servo
that referenced
this pull request
Mar 28, 2024
MunishMummadi
pushed a commit
to MunishMummadi/servo
that referenced
this pull request
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes are:
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors