Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors on custom element :host selector #22

Closed
madeleineostoja opened this issue May 1, 2018 · 1 comment
Closed

Errors on custom element :host selector #22

madeleineostoja opened this issue May 1, 2018 · 1 comment

Comments

@madeleineostoja
Copy link

madeleineostoja commented May 1, 2018 •
edited
Loading

Running subfont over any styles that include a :host selector (ie: custom elements) causes jsdom to freak out with SyntaxError: Unknown pseudo-class selector ":host". Assume it's related to jsdom/jsdom#1030.

Any ideas for a workaround? I'm not at all familiar with jsdom, but since the error is just that it's an unrecognised selector, can we make a whitelist of selectors or something? Wouldn't be an issue for subfont to just ignore :host selectors IMO.
papandreou added a commit to assetgraph/assetgraph that referenced this issue May 1, 2018
@papandreou
getTextByFontProperties: Don't die when there's a :host(...) selector…
ecbc16b 
… that alters properties that we are tracing

Addresses Munter/subfont#22
@papandreou
Copy link
Collaborator

@seaneking, thanks for reporting. Should be fixed in 3.2.2 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@papandreou @madeleineostoja