-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
highlightjs dependency removed from ngx-highlight.js? #283
Comments
No it was not removed! what is your issue? |
Hi MurhafSousli,
thanks for replying back to me
Issue was I followed instructions . but it actually imported alpha version
11.xxx when i checked its package.json file hightlight.js and other
dependencies were not there
then I used laser version like 10.0.0 , which has highlight.js though still
missing few others but atleat now i got hightlight.ts
one more thing for typescript file sometimes it shows Component as keyworrd
and sometimes not
Regards
Rajesh
…On Sun, 12 May, 2024, 21:32 Murhaf Sousli, ***@***.***> wrote:
No it was not removed! what is your issue?
—
Reply to this email directly, view it on GitHub
<#283 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKLKYE2TQNV54BHQZX46DXLZB6HA5AVCNFSM6AAAAABHSRT5JKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBWGI4TSOBWGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Actually it really was removed and I highly recommend to add it back to the project's package.json, otherwise we have to manually install this dependency on our own, which doesn't make much sense IMHO. See diff |
MurhafSousli
added a commit
that referenced
this issue
May 29, 2024
MurhafSousli
added a commit
that referenced
this issue
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Removed dependency from ngx-hjightjs?
"dependencies": {
"highlight.js": "^11.5.1",
"highlightjs-line-numbers.js": "^2.8.0",
"tslib": "^2.0.0"
},
Bug Report or Feature Request (mark with an
x
)OS and Version?
Versions
Repro steps
The log given by the failure
Desired functionality
Mention any other details that might be useful
The text was updated successfully, but these errors were encountered: